GNU bug report logs - #59601
29.0.50; csharp-mode variables missing prefix

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59601: closed (29.0.50; csharp-mode variables missing prefix)
Date: Sun, 10 Sep 2023 21:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 10 Sep 2023 14:30:26 -0700
with message-id <CADwFkmmWowRXAMk9NFQELoKVQEMUiYFpmDJ9=RGM5y=39x21Zw <at> mail.gmail.com>
and subject line Re: bug#59601: 29.0.50; csharp-mode variables missing prefix
has caused the debbugs.gnu.org bug report #59601,
regarding 29.0.50; csharp-mode variables missing prefix
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59601: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59601
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; csharp-mode variables missing prefix
Date: Sat, 26 Nov 2022 00:03:45 -0800

Severity: wishlist

Should these variables have the prefix `csharp-'?

    `codedoc-font-lock-doc-comments'
    `codedoc-font-lock-keywords'

I also see that `codedoc-font-lock-keywords' seems to be unused?

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: Jostein Kjønigsen <jostein <at> kjonigsen.net>,
 59601-done <at> debbugs.gnu.org, Theodor Thornhill <theo <at> thornhill.no>
Subject: Re: bug#59601: 29.0.50; csharp-mode variables missing prefix
Date: Sun, 10 Sep 2023 14:30:26 -0700

Alan Mackenzie <acm <at> muc.de> writes:

> The codedoc variables should _not_ have a csharp- prefix.  Conceptually,
> codedoc is not part of csharp-mode, and could start being used by any CC
> Mode mode, just as gtkdoc is used by both C and C++ modes.
>
> Also, "codedoc" (like "gtkdoc", etc.) is prefixed to
> "-font-lock-doc-comments" and the result interned to get the function to
> fontify the doc comments.  Thus codedoc-font-lock-doc-comments _will_ be
> getting used.
>
> So, yes, the naming convention is essential to the working of CC Mode's
> doc comments.
>
> Whether it would be the Right Thing to add codedoc to CC Mode itself,
> I'm not sure.  doxygen was added quite recently, but that is genuinely a
> language independent format.  I'm a little worried about getting some
> coupling between, say, csharp-mode and CC Mode where there wasn't any
> before.

Thank you, that clears things up.  I agree that we should not do any
changes here, and we certainly want to avoid any coupling if we don't
need it.  Thank you for taking the time to explain.

I opened this bug, so I hope that it will be fine if I close it.
I'm therefore doing that with this email.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.