GNU bug report logs - #59438
29.0.50; [PATCH] Make defvar's into defcustom's in tab-line

Previous Next

Full log

View this message in rfc822 format

From: Gabriel <gabriel376 <at> hotmail.com>
To: 59438 <at> debbugs.gnu.org
Subject: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line
Date: Mon, 21 Nov 2022 06:25:17 -0300

[Message part 1 (text/plain, inline)]

Description:

Please find attached a patch that proposes the following minor changes
to tab-line.  I can refactor the patch if we decide that some change are
not worth or if it's better to split it into smaller patches.

1) Turn the following defvar's into defcustom's:

- `tab-line-tabs-buffer-group-function'
- `tab-line-tabs-buffer-group-sort-function'
- `tab-line-tabs-buffer-groups-sort-function'

2) Add conditional around function call of
`tab-line-tabs-buffer-groups-sort-function', in
`tab-line-tabs-buffer-groups'.  This guards against nil values, similar
to how `tab-line-tabs-buffer-group-sort-function is handled, making the
behavior more consistent across these two (similar) variables.

Should we announce these "new" defcustom's in NEWS?

[0001-Make-defvar-s-into-defcustom-s-in-tab-line.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

---
Gabriel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.