GNU bug report logs - #59437
[PATCH] gnu: Add mympd.

Previous Next

Package: guix-patches;

Reported by: mirai <at> makinata.eu

Date: Mon, 21 Nov 2022 09:03:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59437 in the body.
You can then email your comments to 59437 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#59437; Package guix-patches. (Mon, 21 Nov 2022 09:03:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to mirai <at> makinata.eu:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 21 Nov 2022 09:03:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mirai <at> makinata.eu
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH] gnu: Add mympd.
Date: Mon, 21 Nov 2022 00:26:39 +0000
From: Bruno Victal <mirai <at> makinata.eu>

* gnu/packages/mpd.scm (mympd): New variable.
---
 gnu/packages/mpd.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 4e9cb0cb37..881065d103 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -55,6 +55,7 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages libusb)
+  #:use-module (gnu packages lua)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -66,6 +67,7 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
+  #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pretty-print)
   #:use-module (gnu packages python)
@@ -74,7 +76,9 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages web)
   #:use-module (gnu packages xiph))
 
 (define-public libmpdclient
@@ -561,3 +565,28 @@ (define-public mpdevil
 Instead of maintaining a client side database of your music library,
 mpdevil loads all tags and covers on demand.")
     (license license:gpl3+)))
+
+(define-public mympd
+  (package
+    (name "mympd")
+    (version "10.1.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jcorporation/myMPD")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0cw21sz8xyfz7p8yi03mhriqadrm11x1kqw0pw61v1dkbw13q79c"))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f))
+    (native-inputs (list jq perl))
+    (inputs (list flac libid3tag lua openssl pcre2))
+    (home-page "https://jcorporation.github.io/")
+    (synopsis "Web-based MPD client")
+    (description
+     "myMPD is a standalone and mobile friendly web mpd client with
+a tiny footprint and advanced features.")
+    (license license:gpl3+)))

base-commit: 99ba4ddb03b396f56764a25317f40d4501380704
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59437; Package guix-patches. (Mon, 21 Nov 2022 17:10:01 GMT) Full text and rfc822 format available.

Message #8 received at 59437 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: <mirai <at> makinata.eu>, <59437 <at> debbugs.gnu.org>
Subject: Re: [bug#59437] [PATCH] gnu: Add mympd.
Date: Mon, 21 Nov 2022 17:09:22 +0000
Heya,

On Mon Nov 21, 2022 at 12:26 AM GMT,  wrote:
> * gnu/packages/mpd.scm (mympd): New variable.

> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm

> @@ -561,3 +565,28 @@ (define-public mpdevil

> +    (arguments
> +     '(#:tests? #f))

Please explain why tests are disabled in a comment. Also, please use

  (list ...)

rather than

  '(...)

for arguments.

> +    (description
> +     "myMPD is a standalone and mobile friendly web mpd client with
> +a tiny footprint and advanced features.")

This is a bit markety, I think. How about this?

  (description
   "MyMPD is a mobile-friendly web client for the MPD music
player daemon.")

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#59437; Package guix-patches. (Tue, 22 Nov 2022 01:29:11 GMT) Full text and rfc822 format available.

Message #11 received at 59437 <at> debbugs.gnu.org (full text, mbox):

From: mirai <at> makinata.eu
To: 59437 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v2] gnu: Add mympd.
Date: Mon, 21 Nov 2022 17:50:32 +0000
From: Bruno Victal <mirai <at> makinata.eu>

* gnu/packages/mpd.scm (mympd): New variable.
---
 gnu/packages/mpd.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 4e9cb0cb37..4a307d7c49 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -55,6 +55,7 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages libusb)
+  #:use-module (gnu packages lua)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -66,6 +67,7 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
+  #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pretty-print)
   #:use-module (gnu packages python)
@@ -74,7 +76,9 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages web)
   #:use-module (gnu packages xiph))
 
 (define-public libmpdclient
@@ -561,3 +565,27 @@ (define-public mpdevil
 Instead of maintaining a client side database of your music library,
 mpdevil loads all tags and covers on demand.")
     (license license:gpl3+)))
+
+(define-public mympd
+  (package
+    (name "mympd")
+    (version "10.1.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jcorporation/myMPD")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0cw21sz8xyfz7p8yi03mhriqadrm11x1kqw0pw61v1dkbw13q79c"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list #:tests? #f)) ; no test target
+    (native-inputs (list jq perl))
+    (inputs (list flac libid3tag lua openssl pcre2))
+    (home-page "https://jcorporation.github.io/")
+    (synopsis "Web-based MPD client")
+    (description "MyMPD is a mobile-friendly web client for the MPD music
+player daemon.")
+    (license license:gpl3+)))

base-commit: 2c9635cb47b0f52de635e93ebd137f1f7191c5fd
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59437; Package guix-patches. (Tue, 22 Nov 2022 04:39:01 GMT) Full text and rfc822 format available.

Message #14 received at 59437 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: <mirai <at> makinata.eu>, <59437 <at> debbugs.gnu.org>
Subject: Re: [bug#59437] [PATCH v2] gnu: Add mympd.
Date: Tue, 22 Nov 2022 04:38:04 +0000
On Mon Nov 21, 2022 at 5:50 PM GMT,  wrote:
> * gnu/packages/mpd.scm (mympd): New variable.

This LGTM! :)

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#59437; Package guix-patches. (Tue, 22 Nov 2022 16:13:02 GMT) Full text and rfc822 format available.

Message #17 received at 59437 <at> debbugs.gnu.org (full text, mbox):

From: mirai <at> makinata.eu
To: 59437 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v3] gnu: Add mympd.
Date: Tue, 22 Nov 2022 16:11:36 +0000
From: Bruno Victal <mirai <at> makinata.eu>

* gnu/packages/mpd.scm (mympd): New variable.
---
new upstream release (v10.1.2)

 gnu/packages/mpd.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 0c8dc16cf9..cd37d4682c 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -56,6 +56,7 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages libusb)
+  #:use-module (gnu packages lua)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -67,6 +68,7 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
+  #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pretty-print)
   #:use-module (gnu packages python)
@@ -76,7 +78,9 @@ (define-module (gnu packages mpd)
   #:use-module (gnu packages serialization)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages web)
   #:use-module (gnu packages xiph))
 
 (define-public libmpdclient
@@ -573,3 +577,27 @@ (define-public mpdevil
 Instead of maintaining a client side database of your music library,
 mpdevil loads all tags and covers on demand.")
     (license license:gpl3+)))
+
+(define-public mympd
+  (package
+    (name "mympd")
+    (version "10.1.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jcorporation/myMPD")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1cqq09j7mi7dz5y6l7i0sa6vi2n5zrndnrxnqsi4vcg99fc2vwv8"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list #:tests? #f)) ; no test target
+    (native-inputs (list jq perl))
+    (inputs (list flac libid3tag lua openssl pcre2))
+    (home-page "https://jcorporation.github.io/")
+    (synopsis "Web-based MPD client")
+    (description "MyMPD is a mobile-friendly web client for the MPD music
+player daemon.")
+    (license license:gpl3+)))

base-commit: b8d4c323f5d089dd800b358143d5bae26c965404
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59437; Package guix-patches. (Thu, 24 Nov 2022 09:53:02 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: mirai <at> makinata.eu
Cc: 59437-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59437] [PATCH v3] gnu: Add mympd.
Date: Thu, 24 Nov 2022 09:51:53 +0000
[Message part 1 (text/plain, inline)]
mirai <at> makinata.eu writes:

> From: Bruno Victal <mirai <at> makinata.eu>
>
> * gnu/packages/mpd.scm (mympd): New variable.
> ---
> new upstream release (v10.1.2)
>
>  gnu/packages/mpd.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)

Thanks both! I've pushed this to master as
42898ae8ca25347a4b889bd44203ee7675f0c407.

Chris
[signature.asc (application/pgp-signature, inline)]

Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Thu, 24 Nov 2022 09:53:03 GMT) Full text and rfc822 format available.

Notification sent to mirai <at> makinata.eu:
bug acknowledged by developer. (Thu, 24 Nov 2022 09:53:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 22 Dec 2022 12:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 275 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.