GNU bug report logs - #59417
[PATCH] gnu: Add emacs-on.

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: jgart <jgart <at> dismail.de>
Cc: 59417-done <at> debbugs.gnu.org, 59417 <at> debbugs.gnu.org
Subject: [bug#59417] [PATCH] gnu: Add emacs-on.
Date: Mon, 21 Nov 2022 14:40:58 +0000

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-on): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)

Thanks, I've pushed this to master as
f0cc7542f535cd0ccb75352cabc465a8dc1b1551.

Note that I did move the package definition to not be so close to the
bottom of the module. Thanks for following the comment and not putting
it right at the bottom, but the other important bit is "place them above
by existing packages with similar functionality or similar names".

The intent with that is to avoid Git conflicts when several packages are
added in the same place. For example, you also sent this patch
https://issues.guix.gnu.org/59429 that adds emacs-ukrainian-holidays in
the same place. That's just asking for Git trouble!

I normally just search for the start of the package name, e.g. emacs-o
and then find a similarly named package to place the new one by,
e.g. emacs-on-screen in this case.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.