GNU bug report logs - #59416
[PATCH staging 0/1] gnu: ppsspp: Drop OGLCompiler andOSDependent from glslang libs.

Previous Next

To reply to this bug, email your comments to 59416 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dan <i <at> dan.games>
To: guix-patches <at> gnu.org
Subject: [PATCH staging 0/1] gnu: ppsspp: Drop OGLCompiler andOSDependent from
 glslang libs.
Date: Mon, 21 Nov 2022 01:56:05 +0800

The recent update on vulkan-sdk packages breaks the build of ppsspp on the
staging branch[1].  This patch tries to drops unused glslang libs from the
CMakeLists.txt file of ppsspp, following the recent changes made on
glslang[2].

[1]: http://ci.guix.gnu.org/build/1751089/details
[2]: https://github.com/KhronosGroup/glslang/commit/7cd519511c32d7e86d901c7ed231cb84c652d18d

dan (1):
  gnu: ppsspp: Drop OGLCompiler and OSDependent from glslang libs.

 gnu/packages/emulators.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

-- 
2.38.1

Message #8 received at 59416 <at> debbugs.gnu.org (full text, mbox):

From: dan <i <at> dan.games>
To: 59416 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: ppsspp: Drop OGLCompiler and OSDependent from
 glslang libs.
Date: Mon, 21 Nov 2022 02:00:58 +0800

* gnu/packages/emulators.scm (ppsspp) [arguments]: Drop OGLCompiler and
OSDependent from lists of glslang libraries.
---
 gnu/packages/emulators.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 28d3e0ca9a..2ed5420aca 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2021 Felix Gruber <felgru <at> posteo.net>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
+;;; Copyright © 2021 dan <i <at> dan.games>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2317,7 +2318,14 @@ (define-public ppsspp
            ;; Since we are not including git as an input, PPSSPP is confused
            ;; about its version.  Let's fix that here.
            (substitute* "git-version.cmake"
-             (("unknown") ,version))))))
+             (("unknown") ,version))
+           ;; We've updated the glslang in guix to match the latest vulkan-sdk
+           ;; version, while the glslang ppsspp vendored is a 2-year old
+           ;; version.  We have to manually remove these from glslang libs
+           ;; list to successfully build the package.  For more info, see:
+           ;; https://github.com/KhronosGroup/glslang/commit/7cd519511c32d7e86d901c7ed231cb84c652d18d
+           (substitute* "CMakeLists.txt"
+             (("OGLCompiler OSDependent") ""))))))
     (build-system cmake-build-system)
     (native-inputs (list pkg-config python))
     (inputs (list bash
-- 
2.38.1

Message #11 received at 59416 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: dan <i <at> dan.games>, 59416 <at> debbugs.gnu.org
Subject: Re: [PATCH staging 0/1] gnu: ppsspp: Drop OGLCompiler
 andOSDependent from glslang libs.
Date: Tue, 22 Nov 2022 21:16:02 +0100

Am Montag, dem 21.11.2022 um 01:56 +0800 schrieb dan:
> The recent update on vulkan-sdk packages breaks the build of ppsspp
> on the staging branch[1].  This patch tries to drops unused glslang
> libs from the CMakeLists.txt file of ppsspp, following the recent
> changes made on glslang[2].
> 
> [1]: http://ci.guix.gnu.org/build/1751089/details
You probably want to update this link, but ppsspp on staging is
currently waiting on CI.

> [2]:
> https://github.com/KhronosGroup/glslang/commit/7cd519511c32d7e86d901c7ed231cb84c652d18d
> 
> dan (1):
>   gnu: ppsspp: Drop OGLCompiler and OSDependent from glslang libs.
Have you tested whether this actually works as intended, i.e. whether
OpenGL and Linux-specific features continue to work?

Cheers

Message #14 received at 59416 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: dan <i <at> dan.games>,  59416 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: bug#59416: [PATCH staging 0/1] gnu: ppsspp: Drop OGLCompiler
 andOSDependent from glslang libs.
Date: Tue, 21 Mar 2023 09:09:53 -0400

Hi Dan,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Montag, dem 21.11.2022 um 01:56 +0800 schrieb dan:
>> The recent update on vulkan-sdk packages breaks the build of ppsspp
>> on the staging branch[1].  This patch tries to drops unused glslang
>> libs from the CMakeLists.txt file of ppsspp, following the recent
>> changes made on glslang[2].
>> 
>> [1]: http://ci.guix.gnu.org/build/1751089/details
> You probably want to update this link, but ppsspp on staging is
> currently waiting on CI.
>
>> [2]:
>> https://github.com/KhronosGroup/glslang/commit/7cd519511c32d7e86d901c7ed231cb84c652d18d
>> 
>> dan (1):
>>   gnu: ppsspp: Drop OGLCompiler and OSDependent from glslang libs.
> Have you tested whether this actually works as intended, i.e. whether
> OpenGL and Linux-specific features continue to work?

Gentle ping :-).

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.