GNU bug report logs - #5940
[PATCH] cp: treat selinux warnings consistently

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#5940: marked as done ([PATCH] cp: treat selinux warnings
 consistently)
Date: Wed, 14 Apr 2010 00:00:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 14 Apr 2010 00:58:38 +0100
with message-id <4BC5052E.2080308 <at> draigBrady.com>
and subject line Re: bug#5940: [PATCH] cp: treat selinux warnings consistently
has caused the GNU bug report #5940,
regarding [PATCH] cp: treat selinux warnings consistently
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
5940: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5940
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Report bugs to <bug-coreutils <at> gnu.org>
Cc: Ondřej Vašík <ovasik <at> redhat.com>
Subject: [PATCH] cp: treat selinux warnings consistently
Date: Tue, 13 Apr 2010 13:14:36 +0100

[Message part 3 (text/plain, inline)]

I noticed some inconsistencies in how ENOTSUP errors were handled by cp.

$ dd bs=1M count=10 if=/dev/zero of=t.vfat
$ mkfs.vfat t.vfat
$ mkdir m.vfat
$ sudo mount -o loop t.vfat m.vfat
$ ./src/cp --preserve=all a m.vfat/
./src/cp: setting attribute `user.foo' for `user.foo': Permission denied
./src/cp: setting attribute `user.foo2' for `user.foo2': Permission denied
./src/cp: setting attribute `security.capability' for `security.capability': Operation not permitted
./src/cp: preserving permissions for `m.vfat/a': Operation not supported
$ sudo ./src/cp --preserve=all a m.vfat/a
./src/cp: failed to set the security context of `m.vfat/a' to `system_u:object_r:user_home_t:s0': Operation not supported
./src/cp: failed to preserve ownership for `m.vfat/a': Operation not permitted

Notice how one gets "Operation not supported" when the target exists.
The attached should fix it up.

cheers,
Pádraig.

[cp-enotsup-existing.diff (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: 5940-done <at> debbugs.gnu.org
Subject: Re: bug#5940: [PATCH] cp: treat selinux warnings consistently
Date: Wed, 14 Apr 2010 00:58:38 +0100

On 13/04/10 13:14, Pádraig Brady wrote:
> I noticed some inconsistencies in how ENOTSUP errors were handled by cp.
> 
> The attached should fix it up.

I've just pushed this.

cheers,
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.