GNU bug report logs - #5940
[PATCH] cp: treat selinux warnings consistently

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5940 in the body.
You can then email your comments to 5940 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Report bugs to <bug-coreutils <at> gnu.org>
Cc: Ondřej Vašík <ovasik <at> redhat.com>
Subject: [PATCH] cp: treat selinux warnings consistently
Date: Tue, 13 Apr 2010 13:14:36 +0100

[Message part 1 (text/plain, inline)]

I noticed some inconsistencies in how ENOTSUP errors were handled by cp.

$ dd bs=1M count=10 if=/dev/zero of=t.vfat
$ mkfs.vfat t.vfat
$ mkdir m.vfat
$ sudo mount -o loop t.vfat m.vfat
$ ./src/cp --preserve=all a m.vfat/
./src/cp: setting attribute `user.foo' for `user.foo': Permission denied
./src/cp: setting attribute `user.foo2' for `user.foo2': Permission denied
./src/cp: setting attribute `security.capability' for `security.capability': Operation not permitted
./src/cp: preserving permissions for `m.vfat/a': Operation not supported
$ sudo ./src/cp --preserve=all a m.vfat/a
./src/cp: failed to set the security context of `m.vfat/a' to `system_u:object_r:user_home_t:s0': Operation not supported
./src/cp: failed to preserve ownership for `m.vfat/a': Operation not permitted

Notice how one gets "Operation not supported" when the target exists.
The attached should fix it up.

cheers,
Pádraig.

[cp-enotsup-existing.diff (text/x-patch, attachment)]

Message #10 received at 5940-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 5940-done <at> debbugs.gnu.org
Subject: Re: bug#5940: [PATCH] cp: treat selinux warnings consistently
Date: Wed, 14 Apr 2010 00:58:38 +0100

On 13/04/10 13:14, Pádraig Brady wrote:
> I noticed some inconsistencies in how ENOTSUP errors were handled by cp.
> 
> The attached should fix it up.

I've just pushed this.

cheers,
Pádraig

Message #11 received at 5940-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: 5940-done <at> debbugs.gnu.org
Cc: Pádraig Brady <P <at> draigBrady.com>
Subject: Re: bug#5940: [PATCH] cp: treat selinux warnings consistently
Date: Wed, 14 Apr 2010 15:49:37 +0200

Pádraig Brady wrote:
> On 13/04/10 13:14, Pádraig Brady wrote:
>> I noticed some inconsistencies in how ENOTSUP errors were handled by cp.
>>
>> The attached should fix it up.
>
> I've just pushed this.

Thanks.
This looks fine and passes tests on F13 and rawhide.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.