GNU bug report logs - #59397
[PATCH] feature/tree-sitter: Utilize new font-lock faces for more tree-sitter backed modes

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59397: closed ([PATCH] feature/tree-sitter: Utilize new
 font-lock faces for more tree-sitter backed modes)
Date: Wed, 23 Nov 2022 01:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 22 Nov 2022 17:49:51 -0800
with message-id <4EAF68CB-CE82-47A6-B0F1-8A3C7D2236F4 <at> gmail.com>
and subject line Re: bug#59397: [PATCH] feature/tree-sitter: Utilize new font-lock  faces for more tree-sitter backed modes
has caused the debbugs.gnu.org bug report #59397,
regarding [PATCH] feature/tree-sitter: Utilize new font-lock faces for more tree-sitter backed modes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59397: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59397
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Randy Taylor <dev <at> rjt.dev>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] feature/tree-sitter: Utilize new font-lock faces for more
 tree-sitter backed modes
Date: Sun, 20 Nov 2022 03:42:19 +0000

[Message part 3 (text/plain, inline)]

X-Debbugs-CC: casouri <at> gmail.com, theo <at> thornhill.no

This patch adds support for using the new font-lock faces for more tree-sitter backed modes.

js.el:
- For the number feature, is there a better way to match for exactly NaN or Infinity?
- It might be a good idea to make a parent/base mode (ECMA?) like done in c-ts-mode for JS and TS, since there's a bit of overlap. I'm not volunteering though, since I don't use JS or TS ;).

[Message part 4 (text/html, inline)]

[0001-Utilize-new-font-lock-faces-for-more-tree-sitter-bac.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 59397-done <at> debbugs.gnu.org
Subject: Re: bug#59397: [PATCH] feature/tree-sitter: Utilize new font-lock 
 faces for more tree-sitter backed modes
Date: Tue, 22 Nov 2022 17:49:51 -0800

Randy Taylor <dev <at> rjt.dev> writes:

> On Monday, November 21st, 2022 at 22:38, Randy Taylor <dev <at> rjt.dev> wrote:
>> 
>> On Monday, November 21st, 2022 at 16:49, Yuan Fu casouri <at> gmail.com wrote:
>> 
>> > Thanks! I was busy with other things, but I’ll try to merge this soon!
>> > 
>> > Yuan
>> 
>> 
>> No worries, take your time.
>> 
>> It's probably best to merge Theo's first (Bug#59445) since it's smaller, after which I will rebase and post a new patch.
>> 
>
> OK, latest and greatest patch attached.

Thanks! I merged it.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.