GNU bug report logs - #59397
[PATCH] feature/tree-sitter: Utilize new font-lock faces for more tree-sitter backed modes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59397 in the body.
You can then email your comments to 59397 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] feature/tree-sitter: Utilize new font-lock faces for more
 tree-sitter backed modes
Date: Sun, 20 Nov 2022 03:42:19 +0000

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: casouri <at> gmail.com, theo <at> thornhill.no

This patch adds support for using the new font-lock faces for more tree-sitter backed modes.

js.el:
- For the number feature, is there a better way to match for exactly NaN or Infinity?
- It might be a good idea to make a parent/base mode (ECMA?) like done in c-ts-mode for JS and TS, since there's a bit of overlap. I'm not volunteering though, since I don't use JS or TS ;).

[Message part 2 (text/html, inline)]

[0001-Utilize-new-font-lock-faces-for-more-tree-sitter-bac.patch (text/x-patch, attachment)]

Message #8 received at 59397 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Randy Taylor <dev <at> rjt.dev>, 59397 <at> debbugs.gnu.org
Cc: casouri <at> gmail.com
Subject: Re: bug#59397: [PATCH] feature/tree-sitter: Utilize new font-lock
 faces for more tree-sitter backed modes
Date: Mon, 21 Nov 2022 19:52:55 +0100

Randy Taylor <dev <at> rjt.dev> writes:

> X-Debbugs-CC: casouri <at> gmail.com, theo <at> thornhill.no
>
> This patch adds support for using the new font-lock faces for more tree-sitter backed modes.


Nice, thanks :-)

I added some more in a different bug, as I missed this completely!

Message #11 received at 59397 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: theo <at> thornhill.no, 59397 <at> debbugs.gnu.org
Subject: Re: bug#59397: [PATCH] feature/tree-sitter: Utilize new font-lock
 faces for more tree-sitter backed modes
Date: Mon, 21 Nov 2022 13:49:33 -0800

> On Nov 19, 2022, at 7:42 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> X-Debbugs-CC: casouri <at> gmail.com, theo <at> thornhill.no
> 
> This patch adds support for using the new font-lock faces for more tree-sitter backed modes.
> 
> js.el:
> - For the number feature, is there a better way to match for exactly NaN or Infinity?
> - It might be a good idea to make a parent/base mode (ECMA?) like done in c-ts-mode for JS and TS, since there's a bit of overlap. I'm not volunteering though, since I don't use JS or TS ;).
> <0001-Utilize-new-font-lock-faces-for-more-tree-sitter-bac.patch>

Thanks! I was busy with other things, but I’ll try to merge this soon!

Yuan

Message #14 received at 59397 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Yuan Fu <casouri <at> gmail.com>
Cc: theo <at> thornhill.no, 59397 <at> debbugs.gnu.org
Subject: Re: bug#59397: [PATCH] feature/tree-sitter: Utilize new font-lock
 faces for more tree-sitter backed modes
Date: Tue, 22 Nov 2022 03:38:16 +0000

On Monday, November 21st, 2022 at 16:49, Yuan Fu <casouri <at> gmail.com> wrote:

> 
> Thanks! I was busy with other things, but I’ll try to merge this soon!
> 
> Yuan

No worries, take your time.

It's probably best to merge Theo's first (Bug#59445) since it's smaller, after which I will rebase and post a new patch.

Message #17 received at 59397 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Yuan Fu <casouri <at> gmail.com>
Cc: theo <at> thornhill.no, 59397 <at> debbugs.gnu.org
Subject: Re: bug#59397: [PATCH] feature/tree-sitter: Utilize new font-lock
 faces for more tree-sitter backed modes
Date: Tue, 22 Nov 2022 22:21:20 +0000

[Message part 1 (text/plain, inline)]

On Monday, November 21st, 2022 at 22:38, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> On Monday, November 21st, 2022 at 16:49, Yuan Fu casouri <at> gmail.com wrote:
> 
> > Thanks! I was busy with other things, but I’ll try to merge this soon!
> > 
> > Yuan
> 
> 
> No worries, take your time.
> 
> It's probably best to merge Theo's first (Bug#59445) since it's smaller, after which I will rebase and post a new patch.
> 

OK, latest and greatest patch attached.

[0001-Utilize-new-font-lock-faces-for-more-tree-sitter-mod.patch (text/x-patch, attachment)]

Message #22 received at 59397-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 59397-done <at> debbugs.gnu.org
Subject: Re: bug#59397: [PATCH] feature/tree-sitter: Utilize new font-lock 
 faces for more tree-sitter backed modes
Date: Tue, 22 Nov 2022 17:49:51 -0800

Randy Taylor <dev <at> rjt.dev> writes:

> On Monday, November 21st, 2022 at 22:38, Randy Taylor <dev <at> rjt.dev> wrote:
>> 
>> On Monday, November 21st, 2022 at 16:49, Yuan Fu casouri <at> gmail.com wrote:
>> 
>> > Thanks! I was busy with other things, but I’ll try to merge this soon!
>> > 
>> > Yuan
>> 
>> 
>> No worries, take your time.
>> 
>> It's probably best to merge Theo's first (Bug#59445) since it's smaller, after which I will rebase and post a new patch.
>> 
>
> OK, latest and greatest patch attached.

Thanks! I merged it.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.