GNU bug report logs - #59327
[PATCH] gnu: python-pudb: Add missing python-numpy native-input.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59327: closed ([PATCH] gnu: python-pudb: Add missing
 python-numpy native-input.)
Date: Tue, 22 Nov 2022 09:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 22 Nov 2022 09:38:06 +0000
with message-id <87tu2rs4zs.fsf <at> cbaines.net>
and subject line Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.
has caused the debbugs.gnu.org bug report #59327,
regarding [PATCH] gnu: python-pudb: Add missing python-numpy native-input.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59327: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59327
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: python-pudb: Add missing python-numpy native-input.
Date: Wed, 16 Nov 2022 19:48:33 -0600

* gnu/packages/python-xyz.scm (python-pudb): Add missing native-input.
[native-inputs]: Add python-numpy.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a6b1c7e27e..0968f1477f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29153,7 +29153,7 @@ (define-public python-pudb
                     (lambda* (#:key tests? #:allow-other-keys)
                       (when tests?
                         (invoke "pytest" "-vv")))))))
-    (native-inputs (list python-pytest python-pytest-mock))
+    (native-inputs (list python-pytest python-pytest-mock python-numpy))
     (propagated-inputs (list python-jedi python-pygments python-urwid
                              python-urwid-readline))
     (home-page "https://documen.tician.de/pudb/")
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: jgart <jgart <at> dismail.de>
Cc: 59327-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy
 native-input.
Date: Tue, 22 Nov 2022 09:38:06 +0000

[Message part 4 (text/plain, inline)]

jgart <jgart <at> dismail.de> writes:

> On Mon, 21 Nov 2022 08:34:50 -0600 jgart <jgart <at> dismail.de> wrote:
>> I'll check later today and report back.
>
> Oh, that test just passes an empty list if numpy is not available:
>
> https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32
>
> Do we want to run that test with our packaged numpy on [np.float32(5),
> np.zeros(5)]?

That seems fine to me, I've tweaked the commit message to describe it as
an "optional test dependency", rather than "missing". and pushed to
master as eda5e9aaafeacc0e21dbf43200d79b91fc1e38ed.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.