GNU bug report logs - #59327
[PATCH] gnu: python-pudb: Add missing python-numpy native-input.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59327 in the body.
You can then email your comments to 59327 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: python-pudb: Add missing python-numpy native-input.
Date: Wed, 16 Nov 2022 19:48:33 -0600

* gnu/packages/python-xyz.scm (python-pudb): Add missing native-input.
[native-inputs]: Add python-numpy.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a6b1c7e27e..0968f1477f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29153,7 +29153,7 @@ (define-public python-pudb
                     (lambda* (#:key tests? #:allow-other-keys)
                       (when tests?
                         (invoke "pytest" "-vv")))))))
-    (native-inputs (list python-pytest python-pytest-mock))
+    (native-inputs (list python-pytest python-pytest-mock python-numpy))
     (propagated-inputs (list python-jedi python-pygments python-urwid
                              python-urwid-readline))
     (home-page "https://documen.tician.de/pudb/")
-- 
2.38.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: jgart <jgart <at> dismail.de>
Cc: 59327 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy
 native-input.
Date: Mon, 21 Nov 2022 12:10:08 +0000

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/python-xyz.scm (python-pudb): Add missing native-input.
> [native-inputs]: Add python-numpy.
> ---
>  gnu/packages/python-xyz.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What I'm missing here is why you're making the change? It looks to me
that the package builds without python-numpy?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 59327 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy
 native-input.
Date: Mon, 21 Nov 2022 08:34:50 -0600

On Mon, 21 Nov 2022 12:10:08 +0000 Christopher Baines <mail <at> cbaines.net> wrote:
>
> What I'm missing here is why you're making the change? It looks to me
> that the package builds without python-numpy?

Hi,

Does test_get_stringifier currently pass or get ignored in the pudb
package's check phase?

https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L28

I'll check later today and report back.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 59327 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy
 native-input.
Date: Mon, 21 Nov 2022 08:38:22 -0600

On Mon, 21 Nov 2022 08:34:50 -0600 jgart <jgart <at> dismail.de> wrote:
> I'll check later today and report back.

Oh, that test just passes an empty list if numpy is not available:

https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32

Do we want to run that test with our packaged numpy on [np.float32(5), np.zeros(5)]?

all best,

jgart

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: jgart <jgart <at> dismail.de>
Cc: 59327-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy
 native-input.
Date: Tue, 22 Nov 2022 09:38:06 +0000

[Message part 1 (text/plain, inline)]

jgart <jgart <at> dismail.de> writes:

> On Mon, 21 Nov 2022 08:34:50 -0600 jgart <jgart <at> dismail.de> wrote:
>> I'll check later today and report back.
>
> Oh, that test just passes an empty list if numpy is not available:
>
> https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32
>
> Do we want to run that test with our packaged numpy on [np.float32(5),
> np.zeros(5)]?

That seems fine to me, I've tweaked the commit message to describe it as
an "optional test dependency", rather than "missing". and pushed to
master as eda5e9aaafeacc0e21dbf43200d79b91fc1e38ed.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.