GNU bug report logs - #59327
[PATCH] gnu: python-pudb: Add missing python-numpy native-input.

Previous Next

Full log

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: jgart <jgart <at> dismail.de>
Cc: 59327-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy
 native-input.
Date: Tue, 22 Nov 2022 09:38:06 +0000

[Message part 1 (text/plain, inline)]

jgart <jgart <at> dismail.de> writes:

> On Mon, 21 Nov 2022 08:34:50 -0600 jgart <jgart <at> dismail.de> wrote:
>> I'll check later today and report back.
>
> Oh, that test just passes an empty list if numpy is not available:
>
> https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32
>
> Do we want to run that test with our packaged numpy on [np.float32(5),
> np.zeros(5)]?

That seems fine to me, I've tweaked the commit message to describe it as
an "optional test dependency", rather than "missing". and pushed to
master as eda5e9aaafeacc0e21dbf43200d79b91fc1e38ed.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.