GNU bug report logs - #59326
29.0.50; [PATCH] Handle bookmark-relocate error

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59326: closed (29.0.50; [PATCH] Handle bookmark-relocate error)
Date: Sun, 20 Nov 2022 10:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 20 Nov 2022 12:17:54 +0200
with message-id <83pmdi53ql.fsf <at> gnu.org>
and subject line Re: bug#59326: 29.0.50; [PATCH] Handle bookmark-relocate error
has caused the debbugs.gnu.org bug report #59326,
regarding 29.0.50; [PATCH] Handle bookmark-relocate error
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59326: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59326
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Handle bookmark-relocate error
Date: Wed, 16 Nov 2022 22:15:40 -0300

[Message part 3 (text/plain, inline)]

Description:

Currently, Bookmark does not support relocate (bookmark-relocate) for
Types that do not have a filename (e.g.: Eshell, EWW, Man etc).  We
still need to figure out a good way to let Bookmark Types to provide
their own implementation (suggestions are welcome).  While we don't
teach Bookmark to provide such feature, it should handle these cases and
provide an useful error message for users.  See discussion [1].

Steps:

1) emacs -Q (master f793add1758fd01f678698a90f5847b575f63cf8)

2) Run Eshell: M-x eshell RET

3) Add Eshell to Bookmark list: C-x r m RET

4) Open Bookmark list: C-x r l

5) Try to relocate the Eshell bookmark: R

Result: bookmark-relocate: Wrong type argument: stringp, nil

Patch:

A remediation patch is attached. 

[0001-Handle-error-in-bookmark-relocate-when-filename-is-n.patch (text/x-diff, attachment)]

[Message part 5 (text/plain, inline)]

[1] https://mail.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html

---
Gabriel

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 59326-done <at> debbugs.gnu.org
Subject: Re: bug#59326: 29.0.50; [PATCH] Handle bookmark-relocate error
Date: Sun, 20 Nov 2022 12:17:54 +0200

> From: Gabriel <gabriel376 <at> hotmail.com>
> Date: Wed, 16 Nov 2022 22:15:40 -0300
> 
> Currently, Bookmark does not support relocate (bookmark-relocate) for
> Types that do not have a filename (e.g.: Eshell, EWW, Man etc).  We
> still need to figure out a good way to let Bookmark Types to provide
> their own implementation (suggestions are welcome).  While we don't
> teach Bookmark to provide such feature, it should handle these cases and
> provide an useful error message for users.  See discussion [1].
> 
> Steps:
> 
> 1) emacs -Q (master f793add1758fd01f678698a90f5847b575f63cf8)
> 
> 2) Run Eshell: M-x eshell RET
> 
> 3) Add Eshell to Bookmark list: C-x r m RET
> 
> 4) Open Bookmark list: C-x r l
> 
> 5) Try to relocate the Eshell bookmark: R
> 
> Result: bookmark-relocate: Wrong type argument: stringp, nil
> 
> Patch:
> 
> A remediation patch is attached. 

Thanks, installed, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.