GNU bug report logs - #59283
29.0.50; `custom-set-faces' does not respect :height when set on start-up

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59283 in the body.
You can then email your comments to 59283 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mickey Petersen <mickey <at> fyeah.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; `custom-set-faces' does not respect :height when set on
 start-up
Date: Tue, 15 Nov 2022 09:32:46 +0000

Regression from Emacs 28.x.

$ cat face-only-custom.el
(custom-set-faces '(default ((t (:background "black" :foreground
"gainsboro" :weight regular :height 173 :width normal :family "Cascadia
Code")))))

Tested against the bleeding edge today:

./emacs -q --eval "$(cat ~/.emacs.d/face-only-custom.el)"

This applies the font face and colours but _not_ height. Subsequent eval
will correctly apply `:height'.

Note that this is _also_ the case when it is called through the custom
machinery; it is not required to demonstrate the issue though.

Thanks

Mickey.



In GNU Emacs 29.0.50 (build 14, x86_64-pc-linux-gnu, GTK+ Version
 3.24.20, cairo version 1.16.0) of 2022-11-15 built on mickey-work
Repository revision: 0ac626f1d4eba84bd988a16991178ff25a07ece5
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Ubuntu 20.04.3 LTS

Configured using:
 'configure --with-native-compilation --with-json --with-mailutils
 --without-compress-install --with-imagemagick CC=gcc-10'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2
M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP
SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM
GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: en_GB.UTF-8
  value of $LC_NUMERIC: en_GB.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra
help-mode bytecomp byte-compile cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
native-compile emacs)

Memory information:
((conses 16 83846 7146)
 (symbols 48 7110 0)
 (strings 32 22988 1750)
 (string-bytes 1 722632)
 (vectors 16 17600)
 (vector-slots 8 341685 15174)
 (floats 8 30 38)
 (intervals 56 224 0)
 (buffers 984 11))

Message #10 received at 59283 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Mickey Petersen <mickey <at> fyeah.org>
Cc: 59283 <at> debbugs.gnu.org
Subject: Re: bug#59283: 29.0.50; `custom-set-faces' does not respect :height
 when set on start-up
Date: Tue, 15 Nov 2022 20:57:38 +0800

Mickey Petersen <mickey <at> fyeah.org> writes:

> Regression from Emacs 28.x.
>
> $ cat face-only-custom.el
> (custom-set-faces '(default ((t (:background "black" :foreground
> "gainsboro" :weight regular :height 173 :width normal :family "Cascadia
> Code")))))
>
> Tested against the bleeding edge today:
>
> ./emacs -q --eval "$(cat ~/.emacs.d/face-only-custom.el)"
>
> This applies the font face and colours but _not_ height. Subsequent eval
> will correctly apply `:height'.
>
> Note that this is _also_ the case when it is called through the custom
> machinery; it is not required to demonstrate the issue though.
>
> Thanks
>
> Mickey.

This should already be fixed on master.  Please test, thanks.

Message #13 received at 59283 <at> debbugs.gnu.org (full text, mbox):

From: Mickey Petersen <mickey <at> fyeah.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 59283 <at> debbugs.gnu.org
Subject: Re: bug#59283: 29.0.50; `custom-set-faces' does not respect :height
 when set on start-up
Date: Tue, 15 Nov 2022 13:10:53 +0000

On 15/11/2022 12:57 pm, Po Lu wrote:
> Mickey Petersen <mickey <at> fyeah.org> writes:
>
>> Regression from Emacs 28.x.
>>
>> $ cat face-only-custom.el
>> (custom-set-faces '(default ((t (:background "black" :foreground
>> "gainsboro" :weight regular :height 173 :width normal :family "Cascadia
>> Code")))))
>>
>> Tested against the bleeding edge today:
>>
>> ./emacs -q --eval "$(cat ~/.emacs.d/face-only-custom.el)"
>>
>> This applies the font face and colours but _not_ height. Subsequent eval
>> will correctly apply `:height'.
>>
>> Note that this is _also_ the case when it is called through the custom
>> machinery; it is not required to demonstrate the issue though.
>>
>> Thanks
>>
>> Mickey.
> This should already be fixed on master.  Please test, thanks.

That did not appear to fix it.

Mickey

Message #16 received at 59283 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Mickey Petersen <mickey <at> fyeah.org>
Cc: 59283 <at> debbugs.gnu.org
Subject: Re: bug#59283: 29.0.50; `custom-set-faces' does not respect :height
 when set on start-up
Date: Tue, 15 Nov 2022 21:42:23 +0800

Mickey Petersen <mickey <at> fyeah.org> writes:

> On 15/11/2022 12:57 pm, Po Lu wrote:
>> Mickey Petersen <mickey <at> fyeah.org> writes:
>>
>>> Regression from Emacs 28.x.
>>>
>>> $ cat face-only-custom.el
>>> (custom-set-faces '(default ((t (:background "black" :foreground
>>> "gainsboro" :weight regular :height 173 :width normal :family "Cascadia
>>> Code")))))
>>>
>>> Tested against the bleeding edge today:
>>>
>>> ./emacs -q --eval "$(cat ~/.emacs.d/face-only-custom.el)"
>>>
>>> This applies the font face and colours but _not_ height. Subsequent eval
>>> will correctly apply `:height'.
>>>
>>> Note that this is _also_ the case when it is called through the custom
>>> machinery; it is not required to demonstrate the issue though.
>>>
>>> Thanks
>>>
>>> Mickey.
>> This should already be fixed on master.  Please test, thanks.
>
> That did not appear to fix it.
>
> Mickey

Thanks, please try again.

Message #19 received at 59283 <at> debbugs.gnu.org (full text, mbox):

From: Mickey Petersen <mickey <at> fyeah.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 59283 <at> debbugs.gnu.org
Subject: Re: bug#59283: 29.0.50; `custom-set-faces' does not respect :height
 when set on start-up
Date: Tue, 15 Nov 2022 13:45:44 +0000

On 15/11/2022 1:42 pm, Po Lu wrote:
> Mickey Petersen <mickey <at> fyeah.org> writes:
>
>> On 15/11/2022 12:57 pm, Po Lu wrote:
>>> Mickey Petersen <mickey <at> fyeah.org> writes:
>>>
>>>> Regression from Emacs 28.x.
>>>>
>>>> $ cat face-only-custom.el
>>>> (custom-set-faces '(default ((t (:background "black" :foreground
>>>> "gainsboro" :weight regular :height 173 :width normal :family "Cascadia
>>>> Code")))))
>>>>
>>>> Tested against the bleeding edge today:
>>>>
>>>> ./emacs -q --eval "$(cat ~/.emacs.d/face-only-custom.el)"
>>>>
>>>> This applies the font face and colours but _not_ height. Subsequent eval
>>>> will correctly apply `:height'.
>>>>
>>>> Note that this is _also_ the case when it is called through the custom
>>>> machinery; it is not required to demonstrate the issue though.
>>>>
>>>> Thanks
>>>>
>>>> Mickey.
>>> This should already be fixed on master.  Please test, thanks.
>> That did not appear to fix it.
>>
>> Mickey
> Thanks, please try again.
>

I can confirm this fixes the issue. Thanks for the quick turn-around, Po Lu.

Mickey.

Message #22 received at 59283 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Mickey Petersen <mickey <at> fyeah.org>
Cc: 59283 <at> debbugs.gnu.org
Subject: Re: bug#59283: 29.0.50; `custom-set-faces' does not respect :height
 when set on start-up
Date: Tue, 15 Nov 2022 21:50:55 +0800

Mickey Petersen <mickey <at> fyeah.org> writes:

> I can confirm this fixes the issue. Thanks for the quick turn-around, Po Lu.

Sure.  Once the people who opened the other tickets I merged with this
one say it's fixed as well, I'll close this bug.

Thanks for testing.

Message #25 received at 59283 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59283 <at> debbugs.gnu.org, 58912 <at> debbugs.gnu.org
Subject: Re: bug#59283: 29.0.50; `custom-set-faces' does not respect :height
 when set on start-up
Date: Sat, 19 Nov 2022 14:02:14 +0800

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 01.11.2022 03:01, Po Lu wrote:
>> Dmitry Gutov<dgutov <at> yandex.ru>  writes:
>> 
>>> Depends on the attribute.
>>>
>>> If I set :foreground, it is retained both under X and -nw. :background too.
>>>
>>> If I set :underline, it is retained under -nw, but not under X. But
>>> that includes an older branch which I haven't merged master to for a
>>> while, which I use daily.
>>>
>>> Underline similarly appears briefly during startup but then goes
>>> away. Same for :inverse-video. All under X (-nw keeps them).
>>>
>>> Said branch doesn't touch anything display-related, so it should
>>> behave like master a few months ago.
>>>
>>> The difference seems to be that the most recent master also does that
>>> to attributes :height and :family.
>> If you run "xrdb -query", what is printed?
>
> $ xrdb -query
> *customization:	-color
> Xft.dpi:	192
> Xft.antialias:	1
> Xft.hinting:	0
> Xft.hintstyle:	hintnone
> Xft.rgba:	rgb
> Xcursor.size:	48
> Xcursor.theme:	DMZ-White
>
> In case this is still relevant.

Would you please see if Emacs now behaves satisfactorily in this regard?

Message #28 received at 59283 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59283 <at> debbugs.gnu.org, 58912 <at> debbugs.gnu.org
Subject: Re: bug#58912: bug#59283: 29.0.50; `custom-set-faces' does not
 respect :height when set on start-up
Date: Sat, 19 Nov 2022 16:10:47 +0200

On 19.11.2022 08:02, Po Lu via Bug reports for GNU Emacs, the Swiss army 
knife of text editors wrote:
> Dmitry Gutov<dgutov <at> yandex.ru>  writes:
> 
>> On 01.11.2022 03:01, Po Lu wrote:
>>> Dmitry Gutov<dgutov <at> yandex.ru>   writes:
>>>
>>>> Depends on the attribute.
>>>>
>>>> If I set :foreground, it is retained both under X and -nw. :background too.
>>>>
>>>> If I set :underline, it is retained under -nw, but not under X. But
>>>> that includes an older branch which I haven't merged master to for a
>>>> while, which I use daily.
>>>>
>>>> Underline similarly appears briefly during startup but then goes
>>>> away. Same for :inverse-video. All under X (-nw keeps them).
>>>>
>>>> Said branch doesn't touch anything display-related, so it should
>>>> behave like master a few months ago.
>>>>
>>>> The difference seems to be that the most recent master also does that
>>>> to attributes :height and :family.
>>> If you run "xrdb -query", what is printed?
>> $ xrdb -query
>> *customization:	-color
>> Xft.dpi:	192
>> Xft.antialias:	1
>> Xft.hinting:	0
>> Xft.hintstyle:	hintnone
>> Xft.rgba:	rgb
>> Xcursor.size:	48
>> Xcursor.theme:	DMZ-White
>>
>> In case this is still relevant.
> Would you please see if Emacs now behaves satisfactorily in this regard?

As I previously wrote in bug#59306, the fonts seem fine now, and they 
have been the reason for me filing this bug report (#58912). But the 
frame size is still jumpy (something I only noticed later).

So we could close this bug and continue in bug#59306, I suppose?

Message #31 received at 59283-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59283-done <at> debbugs.gnu.org,
 58912-done <at> debbugs.gnu.org
Subject: Re: bug#58912: bug#59283: 29.0.50; `custom-set-faces' does not
 respect :height when set on start-up
Date: Sun, 20 Nov 2022 08:34:42 +0800

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> As I previously wrote in bug#59306, the fonts seem fine now, and they
> have been the reason for me filing this bug report (#58912). But the
> frame size is still jumpy (something I only noticed later).
>
> So we could close this bug and continue in bug#59306, I suppose?

Yes, I guess so.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.