GNU bug report logs - #59245
[PATCH] Add go-dot-mod-mode and go-dot-work-mode to eglot-server-programs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59245 in the body.
You can then email your comments to 59245 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Davide Masserut <dm <at> mssdvd.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add go-dot-mod-mode and go-dot-work-mode to
 eglot-server-programs
Date: Sun, 13 Nov 2022 12:39:39 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

This path adds go-dot-mod-mode and go-dot-work-mode to 
eglot-server-programs.


In GNU Emacs 29.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version
3.24.34, cairo version 1.17.6) of 2022-11-13 built on T480s
Repository revision: 7a9beac46142eb70061c45ef222d72f84b7b18ab
Repository branch: master
System Description: Arch Linux

Configured using:
'configure --sysconfdir=/etc --prefix=/usr --libexecdir=/usr/lib
--localstatedir=/var --with-pgtk --with-native-compilation
'CFLAGS=-march=native -O2 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -g
-ffile-prefix-map=/home/davide/src/emacs-mssdvd-git/src=/usr/src/debug/emacs-mssdvd-git'
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

[0001-Add-go-dot-mod-mode-and-go-dot-work-mode-to-eglot-se.patch (text/patch, attachment)]

Message #8 received at 59245 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Davide Masserut <dm <at> mssdvd.com>, 59245 <at> debbugs.gnu.org
Cc: joaotavora <at> gmail.com
Subject: Re: bug#59245: [PATCH] Add go-dot-mod-mode and go-dot-work-mode to
 eglot-server-programs
Date: Sun, 13 Nov 2022 05:06:10 -0800

Davide Masserut via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> This path adds go-dot-mod-mode and go-dot-work-mode to
> eglot-server-programs.

Thanks for the patch.

For posterity, could you clarify where `go-dot-mod-mode' and
`go-dot-work-mode' are from?  Are they from some external package, and
if so, could you provide a URL?  Thanks in advance.

> From e73ee956cfe46931123a3c11c32ab399d9abd39c Mon Sep 17 00:00:00 2001
> From: Davide Masserut <dm <at> mssdvd.com>
> Date: Sun, 13 Nov 2022 12:30:43 +0100
> Subject: [PATCH] Add go-dot-mod-mode and go-dot-work-mode to
>  eglot-server-programs
>
> * lisp/progmodes/eglot.el (eglot-server-programs): Add new major modes
> to be used with gopls.
> ---
>  lisp/progmodes/eglot.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 97c674f7aa..98d5281d2c 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -206,7 +206,7 @@ eglot-server-programs
>                                  (elm-mode . ("elm-language-server"))
>                                  (mint-mode . ("mint" "ls"))
>                                  (kotlin-mode . ("kotlin-language-server"))
> -                                (go-mode . ("gopls"))
> +                                ((go-mode go-dot-mod-mode go-dot-work-mode) . ("gopls"))
>                                  ((R-mode ess-r-mode) . ("R" "--slave" "-e"
>                                                          "languageserver::run()"))
>                                  (java-mode . ("jdtls"))
> --
> 2.38.1

Message #11 received at 59245 <at> debbugs.gnu.org (full text, mbox):

From: Davide Masserut <dm <at> mssdvd.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: joaotavora <at> gmail.com, 59245 <at> debbugs.gnu.org
Subject: Re: bug#59245: [PATCH] Add go-dot-mod-mode and go-dot-work-mode to
 eglot-server-programs
Date: Sun, 13 Nov 2022 14:10:33 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

> For posterity, could you clarify where `go-dot-mod-mode' and
> `go-dot-work-mode' are from?  Are they from some external 
> package, and
> if so, could you provide a URL?  Thanks in advance.

They are provided by the 'go-mode' package available on melpa and 
nongnu.  The latter version still doesn't have 'go-dot-work-mode'.

https://github.com/dominikh/go-mode.el

Should I update the patch?

Message #14 received at 59245 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Davide Masserut <dm <at> mssdvd.com>
Cc: joaotavora <at> gmail.com, 59245 <at> debbugs.gnu.org
Subject: Re: bug#59245: [PATCH] Add go-dot-mod-mode and go-dot-work-mode to
 eglot-server-programs
Date: Sun, 13 Nov 2022 05:48:20 -0800

close 59245 29.1
thanks

Davide Masserut <dm <at> mssdvd.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> For posterity, could you clarify where `go-dot-mod-mode' and
>> `go-dot-work-mode' are from?  Are they from some external
>> package, and
>> if so, could you provide a URL?  Thanks in advance.
>
> They are provided by the 'go-mode' package available on melpa and
> nongnu.  The latter version still doesn't have 'go-dot-work-mode'.
>
> https://github.com/dominikh/go-mode.el
>
> Should I update the patch?

I think the pointers you've provided here are sufficient.  So I edited
the commit message lightly and I've pushed your patch to master.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.