GNU bug report logs - #59244
[PATCH] services: vpn: Fix type used for profile-service-type

Previous Next

Package: guix-patches;

Reported by: EuAndreh <eu <at> euandre.org>

Date: Sun, 13 Nov 2022 10:48:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59244 in the body.
You can then email your comments to 59244 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#59244; Package guix-patches. (Sun, 13 Nov 2022 10:48:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to EuAndreh <eu <at> euandre.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 13 Nov 2022 10:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: EuAndreh <eu <at> euandre.org>
To: guix-patches <at> gnu.org
Cc: EuAndreh <eu <at> euandre.org>
Subject: [PATCH] services: vpn: Fix type used for profile-service-type
Date: Sun, 13 Nov 2022 07:46:30 -0300

* gnu/services/vpn.scm (wireguard-service-type): Use a list of packages
  for extending profile-service-type instead of the package directly.
---

Right now it gives an error at build time:

  In procedure append: Wrong type argument in position 15 (expecting empty list): #<package wireguard-tools <at> 1.0.20210914 gnu/packages/vpn.scm:1093 7fd437f48dc0>

 gnu/services/vpn.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/vpn.scm b/gnu/services/vpn.scm
index 5cdfa97add..20439223c0 100644
--- a/gnu/services/vpn.scm
+++ b/gnu/services/vpn.scm
@@ -877,6 +877,6 @@ (define wireguard-service-type
           (service-extension activation-service-type
                              wireguard-activation)
           (service-extension profile-service-type
-                             (const wireguard-tools))))
+                             (const (list wireguard-tools)))))
    (description "Set up Wireguard @acronym{VPN, Virtual Private Network}
 tunnels.")))
-- 
2.38.1
Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Sun, 13 Nov 2022 12:57:01 GMT) Full text and rfc822 format available.
Notification sent to EuAndreh <eu <at> euandre.org>:
bug acknowledged by developer. (Sun, 13 Nov 2022 12:57:02 GMT) Full text and rfc822 format available.

Message #10 received at 59244-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: EuAndreh <eu <at> euandre.org>
Cc: 59244-done <at> debbugs.gnu.org
Subject: Re: bug#59244: [PATCH] services: vpn: Fix type used for
 profile-service-type
Date: Sun, 13 Nov 2022 13:56:15 +0100

> * gnu/services/vpn.scm (wireguard-service-type): Use a list of packages
>   for extending profile-service-type instead of the package directly.

Applied, thanks.

Mathieu
Information forwarded to guix-patches <at> gnu.org:
bug#59244; Package guix-patches. (Sun, 13 Nov 2022 14:15:01 GMT) Full text and rfc822 format available.

Message #13 received at 59244 <at> debbugs.gnu.org (full text, mbox):

From: EuAndreh <eu <at> euandre.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 59244 <at> debbugs.gnu.org
Subject: Re: bug#59244: [PATCH] services: vpn: Fix type used for
 profile-service-type
Date: Sun, 13 Nov 2022 14:14:34 +0000

Hmm, using the "wireguard-configuration-wireguard" package is much 
better, I didn't see it being defined in the configuration.

Thanks for the improvement :)
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 12 Dec 2022 12:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 247 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.