GNU bug report logs - #59118
[PATCH] Prefix all itree functions with itree_

Previous Next

Package: emacs;

Reported by: Matt Armstrong <matt <at> rfc20.org>

Date: Tue, 8 Nov 2022 05:30:02 UTC

Severity: normal

Tags: patch

Done: Matt Armstrong <matt <at> rfc20.org>

Bug is archived. No further changes may be made.

Full log


Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org, Matt Armstrong <matt <at> rfc20.org>,
 59118 <at> debbugs.gnu.org
Subject: Re: bug#59118: [PATCH] Prefix all itree functions with itree_
Date: Tue, 08 Nov 2022 08:53:21 +0200
On November 8, 2022 7:29:15 AM GMT+02:00, Matt Armstrong <matt <at> rfc20.org> wrote:
> Tags: patch
> 
> X-Debbugs-CC: Eli Zaretskii <eliz <at> gnu.org>, Basil L. Contovounesios <contovob <at> tcd.ie>
> 
> Steph and I put some effort into prefixing all functions in itree.h with
> itree_.  It would be nice to be consistent with that.


Functions that initialize Emacs subsystems during startup are traditionally called init_FOO and syms_of_FOO.  So I'd rather we left init_itree alone.

As for forget_itree, I don't mind renaming it, although it's largely a wasted effort: that function is only present in the unexec build, and will die of natural causes at some not too distant point.




This bug report was last modified 2 years and 192 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.