GNU bug report logs - #59118
[PATCH] Prefix all itree functions with itree_

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59118 in the body.
You can then email your comments to 59118 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Armstrong <matt <at> rfc20.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Prefix all itree functions with itree_
Date: Mon, 07 Nov 2022 21:29:15 -0800

[Message part 1 (text/plain, inline)]

Tags: patch

X-Debbugs-CC: Eli Zaretskii <eliz <at> gnu.org>, Basil L. Contovounesios <contovob <at> tcd.ie>

Steph and I put some effort into prefixing all functions in itree.h with
itree_.  It would be nice to be consistent with that.


In GNU Emacs 29.0.50 (build 9, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-11-07 built on naz
Repository revision: d04433b96215d7d3387573f19cc315de86f2341a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12201003
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CFLAGS=-O2 -g3''

[0001-Prefix-all-itree-functions-with-itree_.patch (text/patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org, Matt Armstrong <matt <at> rfc20.org>,
 59118 <at> debbugs.gnu.org
Subject: Re: bug#59118: [PATCH] Prefix all itree functions with itree_
Date: Tue, 08 Nov 2022 08:53:21 +0200

On November 8, 2022 7:29:15 AM GMT+02:00, Matt Armstrong <matt <at> rfc20.org> wrote:
> Tags: patch
> 
> X-Debbugs-CC: Eli Zaretskii <eliz <at> gnu.org>, Basil L. Contovounesios <contovob <at> tcd.ie>
> 
> Steph and I put some effort into prefixing all functions in itree.h with
> itree_.  It would be nice to be consistent with that.


Functions that initialize Emacs subsystems during startup are traditionally called init_FOO and syms_of_FOO.  So I'd rather we left init_itree alone.

As for forget_itree, I don't mind renaming it, although it's largely a wasted effort: that function is only present in the unexec build, and will die of natural causes at some not too distant point.

Message #16 received at 59118-done <at> debbugs.gnu.org (full text, mbox):

From: Matt Armstrong <matt <at> rfc20.org>
To: Eli Zaretskii <eliz <at> gnu.org>, 59118-done <at> debbugs.gnu.org
Subject: Re: bug#59118: [PATCH] Prefix all itree functions with itree_
Date: Tue, 08 Nov 2022 08:03:08 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Functions that initialize Emacs subsystems during startup are
> traditionally called init_FOO and syms_of_FOO.  So I'd rather we left
> init_itree alone.
>
> As for forget_itree, I don't mind renaming it, although it's largely a
> wasted effort: that function is only present in the unexec build, and
> will die of natural causes at some not too distant point.

Fair enough, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.