GNU bug report logs - #59097
[PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode.

Previous Next

Package: guix-patches;

Reported by: Aleksandr Vityazev <avityazev <at> posteo.org>

Date: Mon, 7 Nov 2022 07:53:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 59097 <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 59097 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59097] v2[PATCH] gnu: emacs-skempo: Remove dependency on
 emacs-parent-mode.
Date: Mon, 14 Nov 2022 16:23:49 +0000
[Message part 1 (text/plain, inline)]
Hi,
On 2022-11-07, 20:45 +0100, Christopher Baines <mail <at> cbaines.net> wrote:

> While writing the changelog in the commit is good (so thanks for that),
> it's still often important to put something in the commit about why the
> change is being made.

fixed in patch v2 (in attachment).

> That includes this case, I'm left wondering why this propagated-input is
> being removed?
>
> Note that I'm not asking for some detailed and airtight argument for
> making the change, I just want to why you think this is good to do, even
> if that's just "it doesn't seem to be needed".

I don't know exactly what to do in this situation, since emacs-skempo no
longer has any packages on which it depends, I thought it logical to
remove the propagated-inputs field. Is there any reason why this should
not be done?

-- 
Best regards, 
Aleksandr Vityazev
[0001-gnu-emacs-skempo-Remove-dependency-on-emacs-parent-m.patch (text/x-patch, attachment)]

This bug report was last modified 2 years and 273 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.