GNU bug report logs - #59097
[PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59097 in the body.
You can then email your comments to 59097 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode.
Date: Mon, 07 Nov 2022 07:51:48 +0000

* gnu/packages/emacs-xyz.scm (emacs-skempo)[propagated-inputs]:
Remove dependency on emacs-parent-mode.
---
 gnu/packages/emacs-xyz.scm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4bbebd3cd6..27039609fd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4772,8 +4772,6 @@ (define-public emacs-skempo
         (base32
          "0xsr6819qaad0y8rhfrf555c9w7cmgbgkf1a2svgbp7rhhnywl0a"))))
     (build-system emacs-build-system)
-    (propagated-inputs
-     (list emacs-parent-mode))
     (home-page "https://github.com/xFA25E/skempo")
     (synopsis "Enhancements for skeleton/tempo + abbrev")
     (description
-- 
2.38.0



-- 

Aleksandr Vityazev

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Cc: 59097 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59097] [PATCH] gnu: emacs-skempo: Remove dependency on
 emacs-parent-mode.
Date: Mon, 07 Nov 2022 20:45:42 +0100

[Message part 1 (text/plain, inline)]

Aleksandr Vityazev <avityazev <at> posteo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-skempo)[propagated-inputs]:
> Remove dependency on emacs-parent-mode.
> ---
>  gnu/packages/emacs-xyz.scm | 2 --
>  1 file changed, 2 deletions(-)

While writing the changelog in the commit is good (so thanks for that),
it's still often important to put something in the commit about why the
change is being made.

That includes this case, I'm left wondering why this propagated-input is
being removed?

Note that I'm not asking for some detailed and airtight argument for
making the change, I just want to why you think this is good to do, even
if that's just "it doesn't seem to be needed".

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 59097 <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 59097 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59097] v2[PATCH] gnu: emacs-skempo: Remove dependency on
 emacs-parent-mode.
Date: Mon, 14 Nov 2022 16:23:49 +0000

[Message part 1 (text/plain, inline)]

Hi,
On 2022-11-07, 20:45 +0100, Christopher Baines <mail <at> cbaines.net> wrote:

> While writing the changelog in the commit is good (so thanks for that),
> it's still often important to put something in the commit about why the
> change is being made.

fixed in patch v2 (in attachment).

> That includes this case, I'm left wondering why this propagated-input is
> being removed?
>
> Note that I'm not asking for some detailed and airtight argument for
> making the change, I just want to why you think this is good to do, even
> if that's just "it doesn't seem to be needed".

I don't know exactly what to do in this situation, since emacs-skempo no
longer has any packages on which it depends, I thought it logical to
remove the propagated-inputs field. Is there any reason why this should
not be done?

-- 
Best regards, 
Aleksandr Vityazev

[0001-gnu-emacs-skempo-Remove-dependency-on-emacs-parent-m.patch (text/x-patch, attachment)]

Message #22 received at 59097-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Cc: 59097-done <at> debbugs.gnu.org
Subject: Re: [bug#59097] v2[PATCH] gnu: emacs-skempo: Remove dependency on
 emacs-parent-mode.
Date: Thu, 17 Nov 2022 12:51:43 +0100

Hello,

Aleksandr Vityazev <avityazev <at> posteo.org> writes:

> Subject: [PATCH] gnu: emacs-skempo: Remove dependency on
> emacs-parent-mode.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.