GNU bug report logs - #59028
[PATCH] Rewrite the `kill-buffer-delete-auto-save' tests

Previous Next

Package: emacs;

Reported by: Matt Armstrong <matt <at> rfc20.org>

Date: Fri, 4 Nov 2022 22:54:02 UTC

Severity: wishlist

Tags: moreinfo, patch

Done: Matt Armstrong <matt <at> rfc20.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Matt Armstrong <matt <at> rfc20.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59028: closed ([PATCH] Rewrite the `kill-buffer-delete-auto-save'
 tests)
Date: Wed, 16 Nov 2022 18:55:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 16 Nov 2022 10:54:27 -0800
with message-id <87o7t6687w.fsf <at> rfc20.org>
and subject line Re: bug#59028: [PATCH] Rewrite the `kill-buffer-delete-auto-save' tests
has caused the debbugs.gnu.org bug report #59028,
regarding [PATCH] Rewrite the `kill-buffer-delete-auto-save' tests
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59028: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59028
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Matt Armstrong <matt <at> rfc20.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Rewrite the `kill-buffer-delete-auto-save' tests
Date: Fri, 04 Nov 2022 15:53:05 -0700
[Message part 3 (text/plain, inline)]
Tags: patch

Rationale is in the commit description, but it boils down to these tests
being annoying for me recently.  I like to M-x eval-buffer and run tests
interactively, but these tests seemed to work nicely only in batch mode.
In interactive mode they would both fail and issue annoying prompts
"save this modified buffer?" prompts.  In fixing them, I figured out
what they were trying to test and attempted to make that more robust and
clear.

[0003-Rewrite-the-kill-buffer-delete-auto-save-tests.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Matt Armstrong <matt <at> rfc20.org>
To: Stefan Kangas <stefankangas <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 59028-done <at> debbugs.gnu.org
Subject: Re: bug#59028: [PATCH] Rewrite the `kill-buffer-delete-auto-save'
 tests
Date: Wed, 16 Nov 2022 10:54:27 -0800
Stefan Kangas <stefankangas <at> gmail.com> writes:

> Matt Armstrong <matt <at> rfc20.org> writes:
>
>> It may be possible to change ert's batch runner to hide each test's
>> `message' output, perhaps printing it only if the test fails.
>
> That's a good idea.  How about opening a feature request to track it?

Done as bug#59317.

And with that, and Eli's commits, I'll close this bug.  Thanks.


This bug report was last modified 2 years and 285 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.