GNU bug report logs - #59027
[PATCH] clang-format configuration tweaks

Previous Next

Package: emacs;

Reported by: Matt Armstrong <matt <at> rfc20.org>

Date: Fri, 4 Nov 2022 22:51:01 UTC

Severity: normal

Tags: patch

Merged with 59006

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59027 in the body.
You can then email your comments to 59027 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#59027; Package emacs. (Fri, 04 Nov 2022 22:51:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Matt Armstrong <matt <at> rfc20.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 04 Nov 2022 22:51:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Armstrong <matt <at> rfc20.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] clang-format configuration tweaks
Date: Fri, 04 Nov 2022 15:49:50 -0700
[Message part 1 (text/plain, inline)]
Tags: patch

These two patches configure clang-format to format code more like Emacs
does.

[0001-Configure-clang-format-to-use-tabs.patch (text/x-diff, inline)]
From ddcaa8130852a2a4bab91308809b835a5ed2f2c4 Mon Sep 17 00:00:00 2001
From: Matt Armstrong <matt <at> rfc20.org>
Date: Thu, 3 Nov 2022 14:34:03 -0700
Subject: [PATCH 1/6] Configure clang-format to use tabs

* .clang-format (UseTab): Set to "Always", to match
the (indent-tabs-mode . t) in .dir-locals.el
---
 .clang-format | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.clang-format b/.clang-format
index ac9f95c88a8..8a8391c2e47 100644
--- a/.clang-format
+++ b/.clang-format
@@ -21,6 +21,7 @@ MaxEmptyLinesToKeep: 1
 PenaltyBreakBeforeFirstCallParameter: 2000
 SpaceAfterCStyleCast: true
 SpaceBeforeParens: Always
+UseTab: Always
 
 # Local Variables:
 # mode: yaml
-- 
2.35.1

[0002-.clang-format-ForEachMacros-Add-FOR_EACH_LIVE_BUFFER.patch (text/x-diff, inline)]
From ad11e3dfeeadb333515c99c6b5c89dec1cb701c0 Mon Sep 17 00:00:00 2001
From: Matt Armstrong <matt <at> rfc20.org>
Date: Fri, 4 Nov 2022 15:24:57 -0700
Subject: [PATCH 2/6] ; * .clang-format (ForEachMacros): Add
 FOR_EACH_LIVE_BUFFER.

---
 .clang-format | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.clang-format b/.clang-format
index 8a8391c2e47..464375bd418 100644
--- a/.clang-format
+++ b/.clang-format
@@ -6,7 +6,10 @@ BreakBeforeBinaryOperators: All
 BreakBeforeBraces: GNU
 ColumnLimit: 70
 ContinuationIndentWidth: 2
-ForEachMacros: [FOR_EACH_TAIL, FOR_EACH_TAIL_SAFE, ITREE_FOREACH]
+ForEachMacros: [FOR_EACH_TAIL,
+                FOR_EACH_TAIL_SAFE,
+                FOR_EACH_LIVE_BUFFER,
+                ITREE_FOREACH]
 IncludeCategories:
   - Regex: '^<config\.h>$'
     Priority: -1
-- 
2.35.1


Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Sat, 05 Nov 2022 00:56:02 GMT) Full text and rfc822 format available.

Notification sent to Matt Armstrong <matt <at> rfc20.org>:
bug acknowledged by developer. (Sat, 05 Nov 2022 00:56:02 GMT) Full text and rfc822 format available.

Message #10 received at 59027-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Matt Armstrong <matt <at> rfc20.org>, 59027-done <at> debbugs.gnu.org
Subject: Re: bug#59027: [PATCH] clang-format configuration tweaks
Date: Fri, 4 Nov 2022 17:55:36 -0700
Matt Armstrong <matt <at> rfc20.org> writes:

> These two patches configure clang-format to format code more like Emacs
> does.

Thanks, pushed to master.




Forcibly Merged 59006 59027. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 11 Nov 2022 12:56:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 10 Dec 2022 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 244 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.