GNU bug report logs - #58948
29.0.50; Add :noquery to 'make-network-process' used by eglot

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Tue, 1 Nov 2022 17:58:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 58948 <at> debbugs.gnu.org
Subject: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot
Date: Wed, 02 Nov 2022 10:53:50 +0100

>>>>> On Tue, 01 Nov 2022 19:45:42 +0200, Juri Linkov <juri <at> linkov.net> said:

    Juri> Tags: patch
    Juri> Every time while exiting Emacs, an internal process is displayed and
    Juri> asked whether to exit.

    Juri> Eglot already uses `:noquery t' in two places for `make-process',
    Juri> but can't use the same for `open-network-stream' because it's still unhandled.
    Juri> Here is the patch that adds it:

I guess this is ok, although itʼs missing documentation and a commit
message :-)

Iʼm even tempted to say that unrecognized keyword arguments should
just be passed on to `make-network-process' as-is, but thatʼs a bigger
and riskier change.

Robert
--
This bug report was last modified 2 years and 259 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.