GNU bug report logs - #58948
29.0.50; Add :noquery to 'make-network-process' used by eglot

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58948 in the body.
You can then email your comments to 58948 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Add :noquery to 'make-network-process' used by eglot
Date: Tue, 01 Nov 2022 19:45:42 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

Every time while exiting Emacs, an internal process is displayed and
asked whether to exit.

Eglot already uses `:noquery t' in two places for `make-process',
but can't use the same for `open-network-stream' because it's still unhandled.
Here is the patch that adds it:

[make-network-process-noquery.patch (text/x-diff, inline)]

diff --git a/lisp/net/network-stream.el b/lisp/net/network-stream.el
index 38a5e14c946..c092fd5f012 100644
--- a/lisp/net/network-stream.el
+++ b/lisp/net/network-stream.el
@@ -195,6 +195,7 @@ open-network-stream
 	(make-network-process :name name :buffer buffer
 			      :host (puny-encode-domain host) :service service
 			      :nowait (plist-get parameters :nowait)
+			      :noquery (plist-get parameters :noquery)
                               :tls-parameters
                               (plist-get parameters :tls-parameters)
                               :coding (plist-get parameters :coding))
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 0a0d73eb6d2..204121045a0 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1200,7 +1200,8 @@ eglot--connect
                                (pcase-let ((`(,connection . ,inferior)
                                             (eglot--inferior-bootstrap
                                              readable-name
-                                             contact)))
+                                             contact
+                                             '(:noquery t))))
                                  (setq autostart-inferior-process inferior)
                                  connection))))
                 ((stringp (car contact))

Message #8 received at 58948 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 58948 <at> debbugs.gnu.org
Subject: Re: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used
 by eglot
Date: Wed, 02 Nov 2022 10:53:50 +0100

>>>>> On Tue, 01 Nov 2022 19:45:42 +0200, Juri Linkov <juri <at> linkov.net> said:

    Juri> Tags: patch
    Juri> Every time while exiting Emacs, an internal process is displayed and
    Juri> asked whether to exit.

    Juri> Eglot already uses `:noquery t' in two places for `make-process',
    Juri> but can't use the same for `open-network-stream' because it's still unhandled.
    Juri> Here is the patch that adds it:

I guess this is ok, although itʼs missing documentation and a commit
message :-)

Iʼm even tempted to say that unrecognized keyword arguments should
just be passed on to `make-network-process' as-is, but thatʼs a bigger
and riskier change.

Robert
-- 

Message #11 received at 58948 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 58948 <at> debbugs.gnu.org
Subject: Re: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used
 by eglot
Date: Wed, 02 Nov 2022 20:22:52 +0200

close 58948 29.0.50
thanks

>     Juri> Tags: patch
>     Juri> Every time while exiting Emacs, an internal process is displayed and
>     Juri> asked whether to exit.
>
>     Juri> Eglot already uses `:noquery t' in two places for `make-process',
>     Juri> but can't use the same for `open-network-stream' because it's still unhandled.
>     Juri> Here is the patch that adds it:
>
> I guess this is ok, although itʼs missing documentation and a commit
> message :-)

Thanks for reviewing, now pushed with doc changes.

> Iʼm even tempted to say that unrecognized keyword arguments should
> just be passed on to `make-network-process' as-is, but thatʼs a bigger
> and riskier change.

Agreed.  Maybe then more parameters of make-network-process
could be copied to open-network-stream manually one by one.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.