GNU bug report logs - #58948
29.0.50; Add :noquery to 'make-network-process' used by eglot

Previous Next

Full log

Message #13 received at control <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 58948 <at> debbugs.gnu.org
Subject: Re: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used
 by eglot
Date: Wed, 02 Nov 2022 20:22:52 +0200

close 58948 29.0.50
thanks

>     Juri> Tags: patch
>     Juri> Every time while exiting Emacs, an internal process is displayed and
>     Juri> asked whether to exit.
>
>     Juri> Eglot already uses `:noquery t' in two places for `make-process',
>     Juri> but can't use the same for `open-network-stream' because it's still unhandled.
>     Juri> Here is the patch that adds it:
>
> I guess this is ok, although itʼs missing documentation and a commit
> message :-)

Thanks for reviewing, now pushed with doc changes.

> Iʼm even tempted to say that unrecognized keyword arguments should
> just be passed on to `make-network-process' as-is, but thatʼs a bigger
> and riskier change.

Agreed.  Maybe then more parameters of make-network-process
could be copied to open-network-stream manually one by one.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.