GNU bug report logs - #58839
29.0.50; project-kill-buffer fails when Eglot is running

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Fri, 28 Oct 2022 12:58:01 UTC

Severity: normal

Found in version 29.0.50

Full log


Message #254 received at 58839 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: João Távora <joaotavora <at> gmail.com>
Cc: philipk <at> posteo.net, Eli Zaretskii <eliz <at> gnu.org>,
 manuel.uberti <at> inventati.org, 58839 <at> debbugs.gnu.org
Subject: Re: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer
 fails when Eglot is running
Date: Fri, 4 Nov 2022 03:13:07 +0200
On 01.11.2022 13:36, João Távora wrote:
> On Mon, Oct 31, 2022 at 10:51 PM Dmitry Gutov <dgutov <at> yandex.ru 
> <mailto:dgutov <at> yandex.ru>> wrote:
> 
>  > I suggest you try it first.
> 
> It works in my test
> 
>  > Disaster, really?
> 
> The reason I came about the Gnus problem was when using it
> to reply to some emails here and trying out the C-x p k and finding out
> all my Gnus buffers were gone.

I have now pushed the proposed fix, as well as an additional change to 
except Gnus modes (not sure it will be enough -- there might be 
background buffers using some modes that don't derive -- but it seems to 
help in my brief testing).

That's not to mark a final decision, but to fix the immediate issues, 
and to remember them in the code.

The question now is how to better handle packages and features that are 
similar to Gnus in that regard. One alternative option would be to add a 
var through which such modes could opt-out (rather than opt-in). It 
seems more likely that we won't have to update 
project-kill-buffer-conditions often then.

A whitelisting approach seems cleaner/safer, though.




This bug report was last modified 2 years and 280 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.