GNU bug report logs - #58840
29.0.50; Make scheduled reconnects friendlier in ERC

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58840 in the body.
You can then email your comments to 58840 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Make scheduled reconnects friendlier in ERC
Date: Fri, 28 Oct 2022 06:27:56 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

Hi people,

IRC connections die for a good many reasons. But ERC currently lacks a
decent means of staying abreast of scheduled reconnection attempts
(which has reportedly confused and frustrated newer users). And trying
to cancel an attempt (possibly to clear the way for reconnecting
manually) is likewise inconvenient.

The patch below tries to improve the situation somewhat. For starters,
it borrows a "slash" command, /rmreconns, from Irssi and also introduces
a slight variant, /rmreconn (without the "s"). These simply cancel one
or all pending reconnect attempts. Suggestions for alternate names
and/or aliases welcome.

Also included is a tweak to /reconnect to ensure it always cancels an
active timer before connecting. This should allow the lazy/impatient
among us to expedite proceedings in a single command. Also added is a
new "reconnecting in <N>s" mode-line indicator as well as a printed
reminder in the server buffer of the configured wait time when a timer
is first set. Note that the mode line doesn't update automatically
(there's no periodic countdown, IOW), but it *does* update on user
input, e.g., when you move point around. (Hopefully that's sufficient.)

Please offer feedback if you care about this feature. It's not a
priority for me, so if anyone wants this in ERC 5.5 and Emacs 29, please
make that known.

Thanks,
J.P.

P.S. This patch assumes bug#56340's changes have been applied; expect
some benign complaints from the compiler if they haven't.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.17.6) of 2022-10-26 built on localhost
Repository revision: db2ed9f333879e5ac283fb48c8b06ed4022f0af9
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3'
 PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 36089 6500)
 (symbols 48 5118 0)
 (strings 32 13124 1756)
 (string-bytes 1 372990)
 (vectors 16 9304)
 (vector-slots 8 147959 9387)
 (floats 8 21 29)
 (intervals 56 220 0)
 (buffers 1000 10))

[0001-Improve-auto-reconnect-visibility-in-ERC.patch (text/x-patch, attachment)]

Message #8 received at 58840 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 58840 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#58840: 29.0.50; Make scheduled reconnects friendlier in ERC
Date: Fri, 11 Nov 2022 06:07:48 -0800

[Message part 1 (text/plain, inline)]

v2. Added user option to specify function run by reconnect timer.
Factored out reconnect scheduling for use in user code.

[0000-v1-v2.diff (text/x-patch, attachment)]

[0001-Improve-auto-reconnect-visibility-in-ERC.patch (text/x-patch, attachment)]

Message #11 received at 58840 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>
Cc: emacs-erc <at> gnu.org, 58840 <at> debbugs.gnu.org
Subject: Re: bug#58840: 29.0.50; Make scheduled reconnects friendlier in ERC
Date: Sat, 12 Nov 2022 20:11:34 -0800

"J.P." <jp <at> neverwas.me> writes:

> v2. Added user option to specify function run by reconnect timer.
> Factored out reconnect scheduling for use in user code.

Looks good to me after a cursory read.  I didn't test it, but if you
feel confident about it, I think it should go in.  Bonus points for the
regression tests, as always.

Don't forget to add the bug number to the commit message.

Message #14 received at 58840 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: emacs-erc <at> gnu.org, 58840 <at> debbugs.gnu.org
Subject: Re: bug#58840: 29.0.50; Make scheduled reconnects friendlier in ERC
Date: Sun, 13 Nov 2022 07:31:03 -0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> "J.P." <jp <at> neverwas.me> writes:
>
>> v2. Added user option to specify function run by reconnect timer.
>> Factored out reconnect scheduling for use in user code.
>
> Looks good to me after a cursory read.

Wow, thanks a lot for taking a look!

> I didn't test it, but if you feel confident about it, I think it
> should go in.

I'd really like it to, but lot's of stuff's in play right now, so it's
hard to say for sure.

> Don't forget to add the bug number to the commit message.

Ooh, right. Thanks. (I've been living dangerously so far, barely
catching them at the last second, but my luck's probably running out.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.