GNU bug report logs - #58810
29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Subject: bug#58810: closed (Re: bug#58810: 29.0.50; [PATCH]
 'eshell-stringify' sometimes produces wrong results)
Date: Thu, 03 Nov 2022 18:50:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 58810 <at> debbugs.gnu.org.

-- 
58810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58810
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: 58810-done <at> debbugs.gnu.org
Subject: Re: bug#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces
 wrong results
Date: Thu, 3 Nov 2022 11:48:54 -0700

On 10/26/2022 6:22 PM, Jim Porter wrote:
> Attached is a patch with regression tests for 'eshell-stringify' so that 
> this works correctly.

Merged as d2a9dae40057ff16683d9c5f30a3b04500ebc4cf. Closing this bug.

[Message part 3 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results
Date: Wed, 26 Oct 2022 18:22:13 -0700

[Message part 4 (text/plain, inline)]

Starting from "emacs -Q -f -eshell":

  ~ $ echo $(list 'quote 'hello)
  'hell

The last character of "hello" was stripped. That's because 
'eshell-stringify' tries to remove the trailing newline from 
'pp-to-string', but it does so by always stripping the last character 
from the result. Obviously, that only works when the last character 
really is a newline.

Attached is a patch with regression tests for 'eshell-stringify' so that 
this works correctly.

[0001-Only-strip-newlines-when-stringifying-a-value-for-Es.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.