GNU bug report logs - #58810
29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58810 in the body.
You can then email your comments to 58810 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results
Date: Wed, 26 Oct 2022 18:22:13 -0700

[Message part 1 (text/plain, inline)]

Starting from "emacs -Q -f -eshell":

  ~ $ echo $(list 'quote 'hello)
  'hell

The last character of "hello" was stripped. That's because 
'eshell-stringify' tries to remove the trailing newline from 
'pp-to-string', but it does so by always stripping the last character 
from the result. Obviously, that only works when the last character 
really is a newline.

Attached is a patch with regression tests for 'eshell-stringify' so that 
this works correctly.

[0001-Only-strip-newlines-when-stringifying-a-value-for-Es.patch (text/plain, attachment)]

Message #10 received at 58810-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 58810-done <at> debbugs.gnu.org
Subject: Re: bug#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces
 wrong results
Date: Thu, 3 Nov 2022 11:48:54 -0700

On 10/26/2022 6:22 PM, Jim Porter wrote:
> Attached is a patch with regression tests for 'eshell-stringify' so that 
> this works correctly.

Merged as d2a9dae40057ff16683d9c5f30a3b04500ebc4cf. Closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.