GNU bug report logs - #58800
Mark previous-buffer and next-buffer commands as repeatable

Previous Next

Full log

Message #8 received at 58800 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>, 58800 <at> debbugs.gnu.org
Subject: Re: bug#58800: Mark previous-buffer and next-buffer commands as
 repeatable
Date: Wed, 26 Oct 2022 12:52:37 -0700

Damien Cassou <damien <at> cassou.me> writes:

> From 4bafbad18a0a027207399cf4ba71b7775eb873cb Mon Sep 17 00:00:00 2001
> From: Damien Cassou <damien <at> cassou.me>
> Date: Wed, 26 Oct 2022 17:12:14 +0200
> Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as
>  repeatable
>
> * lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
> * lisp/bindings.el (previous-buffer):
> (next-buffer): Mark as repeatable.
>
> Copyright-paperwork-exempt: yes

Do we really need to add "Copyright-paperwork-exempt"?

You already have changes in emacs.git that takes you way above the 15 or
so lines that we could make an exception for, so I guess you have in
fact signed the papers?  AFAIU, the line shouldn't be used in that case.

> ---
>  lisp/bindings.el | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/lisp/bindings.el b/lisp/bindings.el
> index 2e32128274..9005b20a71 100644
> --- a/lisp/bindings.el
> +++ b/lisp/bindings.el
> @@ -1029,6 +1029,14 @@ ctl-x-map
>  (define-key global-map [XF86Back] 'previous-buffer)
>  (put 'previous-buffer :advertised-binding [?\C-x left])
>
> +(defvar-keymap buffer-navigation-repeat-map
> +  :doc "Keymap to repeat `next-buffer' and `previous-buffer'.  Used in `repeat-mode'."
> +  [right] #'next-buffer
> +  [left] #'previous-buffer)

It should be "<right>" and "<left>" here, I think.

> +
> +(put 'next-buffer 'repeat-map 'buffer-navigation-repeat-map)
> +(put 'previous-buffer 'repeat-map 'buffer-navigation-repeat-map)
> +
>  (let ((map minibuffer-local-map))
>    (define-key map "\en"   'next-history-element)
>    (define-key map [next]  'next-history-element)
> --
> 2.36.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.