GNU bug report logs - #58800
Mark previous-buffer and next-buffer commands as repeatable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58800 in the body.
You can then email your comments to 58800 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: bug-gnu-emacs <at> gnu.org
Subject: Mark previous-buffer and next-buffer commands as repeatable
Date: Wed, 26 Oct 2022 17:14:51 +0200

[Message part 1 (text/plain, inline)]

Tags: patch





In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0)
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure
 --prefix=/nix/store/1ihp8r45mw29fdipjmqrm2vk0fvwd86x-emacs-28.2
 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft
 --with-cairo --with-native-compilation'


-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-Mark-previous-buffer-and-next-buffer-commands-as-rep.patch (text/patch, attachment)]

Message #8 received at 58800 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>, 58800 <at> debbugs.gnu.org
Subject: Re: bug#58800: Mark previous-buffer and next-buffer commands as
 repeatable
Date: Wed, 26 Oct 2022 12:52:37 -0700

Damien Cassou <damien <at> cassou.me> writes:

> From 4bafbad18a0a027207399cf4ba71b7775eb873cb Mon Sep 17 00:00:00 2001
> From: Damien Cassou <damien <at> cassou.me>
> Date: Wed, 26 Oct 2022 17:12:14 +0200
> Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as
>  repeatable
>
> * lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
> * lisp/bindings.el (previous-buffer):
> (next-buffer): Mark as repeatable.
>
> Copyright-paperwork-exempt: yes

Do we really need to add "Copyright-paperwork-exempt"?

You already have changes in emacs.git that takes you way above the 15 or
so lines that we could make an exception for, so I guess you have in
fact signed the papers?  AFAIU, the line shouldn't be used in that case.

> ---
>  lisp/bindings.el | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/lisp/bindings.el b/lisp/bindings.el
> index 2e32128274..9005b20a71 100644
> --- a/lisp/bindings.el
> +++ b/lisp/bindings.el
> @@ -1029,6 +1029,14 @@ ctl-x-map
>  (define-key global-map [XF86Back] 'previous-buffer)
>  (put 'previous-buffer :advertised-binding [?\C-x left])
>
> +(defvar-keymap buffer-navigation-repeat-map
> +  :doc "Keymap to repeat `next-buffer' and `previous-buffer'.  Used in `repeat-mode'."
> +  [right] #'next-buffer
> +  [left] #'previous-buffer)

It should be "<right>" and "<left>" here, I think.

> +
> +(put 'next-buffer 'repeat-map 'buffer-navigation-repeat-map)
> +(put 'previous-buffer 'repeat-map 'buffer-navigation-repeat-map)
> +
>  (let ((map minibuffer-local-map))
>    (define-key map "\en"   'next-history-element)
>    (define-key map [next]  'next-history-element)
> --
> 2.36.2

Message #11 received at 58800 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Stefan Kangas <stefankangas <at> gmail.com>, 58800 <at> debbugs.gnu.org
Subject: Re: bug#58800: Mark previous-buffer and next-buffer commands as
 repeatable
Date: Sun, 30 Oct 2022 07:35:04 +0100

[Message part 1 (text/plain, inline)]

Hi Stefan,

Stefan Kangas <stefankangas <at> gmail.com> writes:
> Damien Cassou <damien <at> cassou.me> writes:
> Do we really need to add "Copyright-paperwork-exempt"?

I don't, you are right. Fixed.

>> +(defvar-keymap buffer-navigation-repeat-map
>> +  :doc "Keymap to repeat `next-buffer' and `previous-buffer'.  Used in `repeat-mode'."
>> +  [right] #'next-buffer
>> +  [left] #'previous-buffer)
>
> It should be "<right>" and "<left>" here, I think.

You are right. In the meantime, I switched to Emacs 29 so I can test my
own patches. Sorry. Fixed.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-Mark-previous-buffer-and-next-buffer-commands-as-rep.patch (text/x-patch, attachment)]

Message #14 received at 58800 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>, 58800 <at> debbugs.gnu.org
Subject: Re: bug#58800: Mark previous-buffer and next-buffer commands as
 repeatable
Date: Sun, 30 Oct 2022 06:25:51 -0700

close 58800 29.1
thanks

Damien Cassou <damien <at> cassou.me> writes:

> From c09670b9baa5d5333ba2f9396915b01062b1f2a8 Mon Sep 17 00:00:00 2001
> From: Damien Cassou <damien <at> cassou.me>
> Date: Wed, 26 Oct 2022 17:12:14 +0200
> Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as
>  repeatable
>
> * lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
> * lisp/bindings.el (previous-buffer):
> (next-buffer): Mark as repeatable.

Thanks for the patch.  I pushed it with this improved commit message:

    Make previous-buffer and next-buffer repeatable

    * lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
    * lisp/bindings.el (previous-buffer, next-buffer): Mark as
    repeatable.  (Bug#58800)

I'm consequently closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.