GNU bug report logs - #58621
[PATCH 0/3] import/utils: spdx-string->license: Match case-insensitively and support '+' operator.

Previous Next

Package: guix-patches;

Reported by: Philip McGrath <philip <at> philipmcgrath.com>

Date: Wed, 19 Oct 2022 04:56:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #19 received at 58621-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Philip McGrath <philip <at> philipmcgrath.com>
Cc: 58621-done <at> debbugs.gnu.org
Subject: Re: bug#58621: [PATCH 0/3] import/utils: spdx-string->license:
 Match case-insensitively and support '+' operator.
Date: Fri, 18 Nov 2022 14:45:26 +0100
Hi,

Applied all three patches.  I added trivial tests for
‘spdx-string->license’ and changed ‘substring’ to ‘string-drop-right’,
which I find clearer.

Philip McGrath <philip <at> philipmcgrath.com> skribis:

> +     (and (string-suffix? "+" str)
> +          ;; We try the form with the + to support deprecated identifiers for
> +          ;; GNU licenses (see above).  Here, we handle other uses of +.
> +          (spdx-string->license
> +           (substring str 0 (- (string-length str) 1)))))))

I guess we can remove the “+” forms from the alist now?

Thanks,
Ludo’.




This bug report was last modified 2 years and 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.