GNU bug report logs - #58620
Update blur my shell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58620 in the body.
You can then email your comments to 58620 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Charles <Charles.b.jackson <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Update blur my shell
Date: Wed, 19 Oct 2022 04:25:47 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[Message part 2 (text/html, inline)]

[0001-gnu-gnome-shell-extensions-Update-blur-my-shell-to-v.patch (text/x-patch, attachment)]

Message #8 received at 58620 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: Charles <Charles.b.jackson <at> proton.me>, 58620 <at> debbugs.gnu.org
Subject: Re: Update blur my shell
Date: Thu, 20 Oct 2022 15:01:00 +0200

Am Mittwoch, dem 19.10.2022 um 04:25 +0000 schrieb Charles:

> [PATCH] gnu: gnome-shell-extensions: Update blur my shell to version
>  44.
Should be: "gnu: update gnome-shell-extension-blur-my-shell to 44".
> 
> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-blur-my-shell)
> Update version and hash. Add a phase to move the contents of the src
> and resources directories to project root so they get installed
> properly.
Break lines between changes and make clear what's changed.  Use
indicators such as [#:phases].

> ---
>  gnu/packages/gnome-xyz.scm | 31 ++++++++++++++++++++++---------
>  1 file changed, 22 insertions(+), 9 deletions(-)
> 
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index 68166978a1..89bb9c9d7b 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -996,7 +996,7 @@ (define-public gnome-shell-extension-burn-my-
> windows
>  (define-public gnome-shell-extension-blur-my-shell
>    (package
>      (name "gnome-shell-extension-blur-my-shell")
> -    (version "29")
> +    (version "44")
>      (source
>       (origin
>         (method git-fetch)
> @@ -1006,9 +1006,7 @@ (define-public gnome-shell-extension-blur-my-
> shell
>         (file-name (git-file-name name version))
>         (sha256
>          (base32
> -         "13x7zgaj3dz7lypdv1bgmpmh0f2w53q567zxmhmqimi1gy5mjrvk"))
> -       (snippet
> -        '(begin (delete-file "src/schemas/gschemas.compiled")))))
> +         "0h7yfvrrg5r821mzrp42c09jws06mw6v9avvkfykqj8n8qnslmyx"))))
Why is the snippet removed?
>      (build-system copy-build-system)
>      (arguments
>       `(#:install-plan
> @@ -1016,15 +1014,30 @@ (define-public gnome-shell-extension-blur-my-
> shell
>                  "share/gnome-shell/extensions/"
>                  "blur-my-shell <at> aunetx")
>            #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$"
> "\\.png$"
> -                            "\\.xml$" "\\.compiled$")))
> +                            "\\.svg$" "\\.xml$" "\\.compiled$")))
Note the addition of "\\.svg$" in the ChangeLog. 
>         #:phases
>         (modify-phases %standard-phases
> -         (add-after 'unpack 'cd-src
> -           (lambda _ (chdir "src")))
> -         (add-before 'install 'compile-schemas
> +         (add-after 'unpack 'compile-schemas
>             (lambda _
>               (with-directory-excursion "schemas"
> -               (invoke "glib-compile-schemas" ".")))))))
> +               (invoke "glib-compile-schemas" "."))))
> +         (add-before 'install 'unpack-src
> +           (lambda _
> +             (use-modules (ice-9 ftw))
> +             (define (explode-dir dir)
> +               (for-each
> +                (lambda (file)
> +                  (let ((full-file-name
> +                         (string-append (getcwd) "/" dir "/" file)))
> +                    (rename-file
> +                     full-file-name
> +                     (string-append (getcwd) "/" file))))
> +                (filter (lambda (file)
> +                          (not (or (string=? file ".")
> +                                   (string=? file ".."))))
> +                        (scandir (string-append (getcwd) "/"
> dir)))))
> +             (explode-dir "src")
> +             (explode-dir "resources"))))))
Adjust #:install-plan instead.
>      (native-inputs
>       (list (list glib "bin"))) ; for glib-compile-schemas
>      (home-page "https://github.com/aunetx/blur-my-shell")
> -- 
Cheers

Message #11 received at 58620 <at> debbugs.gnu.org (full text, mbox):

From: Charles <Charles.b.jackson <at> proton.me>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 58620 <at> debbugs.gnu.org
Subject: Re: Update blur my shell
Date: Sat, 22 Oct 2022 04:33:42 +0000

[Message part 1 (text/plain, inline)]

Thank you for the great review, Liliana. Using the install plan makes this so much better. I think I have addressed all your feedback. Updated patch attatched.

------- Original Message -------
On Thursday, October 20th, 2022 at 8:01 AM, Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> wrote:


> Am Mittwoch, dem 19.10.2022 um 04:25 +0000 schrieb Charles:
> 
> > [PATCH] gnu: gnome-shell-extensions: Update blur my shell to version
> > 44.
> 
> Should be: "gnu: update gnome-shell-extension-blur-my-shell to 44".
> 
> > * gnu/packages/gnome-xyz.scm (gnome-shell-extension-blur-my-shell)
> > Update version and hash. Add a phase to move the contents of the src
> > and resources directories to project root so they get installed
> > properly.
> 
> Break lines between changes and make clear what's changed. Use
> indicators such as [#:phases].
> 
> > ---
> > gnu/packages/gnome-xyz.scm | 31 ++++++++++++++++++++++---------
> > 1 file changed, 22 insertions(+), 9 deletions(-)
> > 
> > diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> > index 68166978a1..89bb9c9d7b 100644
> > --- a/gnu/packages/gnome-xyz.scm
> > +++ b/gnu/packages/gnome-xyz.scm
> > @@ -996,7 +996,7 @@ (define-public gnome-shell-extension-burn-my-
> > windows
> > (define-public gnome-shell-extension-blur-my-shell
> > (package
> > (name "gnome-shell-extension-blur-my-shell")
> > - (version "29")
> > + (version "44")
> > (source
> > (origin
> > (method git-fetch)
> > @@ -1006,9 +1006,7 @@ (define-public gnome-shell-extension-blur-my-
> > shell
> > (file-name (git-file-name name version))
> > (sha256
> > (base32
> > - "13x7zgaj3dz7lypdv1bgmpmh0f2w53q567zxmhmqimi1gy5mjrvk"))
> > - (snippet
> > - '(begin (delete-file "src/schemas/gschemas.compiled")))))
> > + "0h7yfvrrg5r821mzrp42c09jws06mw6v9avvkfykqj8n8qnslmyx"))))
> 
> Why is the snippet removed?
> 
> > (build-system copy-build-system)
> > (arguments
> > `(#:install-plan
> > @@ -1016,15 +1014,30 @@ (define-public gnome-shell-extension-blur-my-
> > shell
> > "share/gnome-shell/extensions/"
> > "blur-my-shell <at> aunetx")
> > #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$"
> > "\\.png$"
> > - "\\.xml$" "\\.compiled$")))
> > + "\\.svg$" "\\.xml$" "\\.compiled$")))
> 
> Note the addition of "\\.svg$" in the ChangeLog.
> 
> > #:phases
> > (modify-phases %standard-phases
> > - (add-after 'unpack 'cd-src
> > - (lambda _ (chdir "src")))
> > - (add-before 'install 'compile-schemas
> > + (add-after 'unpack 'compile-schemas
> > (lambda _
> > (with-directory-excursion "schemas"
> > - (invoke "glib-compile-schemas" ".")))))))
> > + (invoke "glib-compile-schemas" "."))))
> > + (add-before 'install 'unpack-src
> > + (lambda _
> > + (use-modules (ice-9 ftw))
> > + (define (explode-dir dir)
> > + (for-each
> > + (lambda (file)
> > + (let ((full-file-name
> > + (string-append (getcwd) "/" dir "/" file)))
> > + (rename-file
> > + full-file-name
> > + (string-append (getcwd) "/" file))))
> > + (filter (lambda (file)
> > + (not (or (string=? file ".")
> > + (string=? file ".."))))
> > + (scandir (string-append (getcwd) "/"
> > dir)))))
> > + (explode-dir "src")
> > + (explode-dir "resources"))))))
> 
> Adjust #:install-plan instead.
> 
> > (native-inputs
> > (list (list glib "bin"))) ; for glib-compile-schemas
> > (home-page "https://github.com/aunetx/blur-my-shell")
> > --
> 
> Cheers

[0001-gnu-Update-gnome-shell-extension-blur-my-shell-to-44.patch (text/x-patch, attachment)]

Message #16 received at 58620-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Charles <Charles.b.jackson <at> proton.me>
Cc: 58620-done <at> debbugs.gnu.org
Subject: Re: Update blur my shell
Date: Sat, 22 Oct 2022 11:07:03 +0200

Am Samstag, dem 22.10.2022 um 04:33 +0000 schrieb Charles:

> Thank you for the great review, Liliana. Using the install plan makes
> this so much better. I think I have addressed all your feedback.
> Updated patch attatched.
Pushed with the following changes:

> +     '(#:install-plan
> +       (let ((install-location
> +              (string-append
> +               "share/gnome-shell/extensions/"
> +               "blur-my-shell <at> aunetx")))
> +         `(("src/" ,install-location)
> +           ("resources/" ,install-location
> +            #:include-regexp ("\\.svg$" "\\.ui"))
> +           ("." ,install-location
> +            #:exclude-regexp ("src/" "resources/")
> +            #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$"
> "\\.png$"
> +                              "\\.xml$" "\\.compiled$"))))
Used a shorter name for install-location for the sake of conciseness.

> -     (list (list glib "bin"))) ; for glib-compile-schemas
> +     (list (list "glib:bin" glib "bin"))) ; for glib-compile-schemas
Dropped this, because the linter warning is a false positive.

I also rewrote the commit message to fall in line with the others.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.