GNU bug report logs -
#58543
29.0.50; The 'q' key is not shown by "C-h ?"
Previous Next
Reported by: Eli Zaretskii <eliz <at> gnu.org>
Date: Sat, 15 Oct 2022 09:41:01 UTC
Severity: normal
Found in version 29.0.50
Done: Philip Kaludercic <philipk <at> posteo.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58543 in the body.
You can then email your comments to 58543 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sat, 15 Oct 2022 09:41:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Eli Zaretskii <eliz <at> gnu.org>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Sat, 15 Oct 2022 09:41:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
As Subject says: "C-h ?" doesn't show the 'q' key, it shows this
instead:
M-x help-quick-or-quit Display the quick help buffer.
This is sub-optimal, I think, and will help users who need this "quick
help" less than it could be.
Thinking about it, perhaps 'q'; should be on the first line shown by
"C-h ?".
In GNU Emacs 29.0.50 (build 2070, i686-pc-mingw32) of 2022-10-15 built
on HOME-C4E4A596F7
Repository revision: e185526d216e544a70b2be77b34b5cb5386762d1
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 5.1.2600
System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)
Configured using:
'configure -C --prefix=/d/usr --with-wide-int
--enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3''
Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP XPM ZLIB
Important settings:
value of $LANG: ENU
locale-coding-system: cp1255
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util time-date subr-x mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils text-property-search
rect face-remap help-mode cl-loaddefs cl-lib rmc iso-transl tooltip
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win
w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads
w32notify w32 lcms2 multi-tty make-network-process emacs)
Memory information:
((conses 16 45646 6965)
(symbols 48 6443 0)
(strings 16 17143 2891)
(string-bytes 1 414102)
(vectors 16 9654)
(vector-slots 8 149052 13047)
(floats 8 29 26)
(intervals 40 464 170)
(buffers 896 11))
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 09:51:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 58543 <at> debbugs.gnu.org (full text, mbox):
Eli Zaretskii <eliz <at> gnu.org> writes:
> As Subject says: "C-h ?" doesn't show the 'q' key, it shows this
> instead:
>
> M-x help-quick-or-quit Display the quick help buffer.
>
> This is sub-optimal, I think, and will help users who need this "quick
> help" less than it could be.
>
> Thinking about it, perhaps 'q'; should be on the first line shown by
> "C-h ?".
Hm... It's rather confusing all over now. All the other commands after
`C-h ?' do the same as typing the commands directly.
That is, `C-h t' shows the Emacs tutorial, and `C-h ? t' does the same.
`C-h q' shows the quick help, but `C-h ? q' doesn't -- it just exits
`help-for-help'.
But the help-for-help says that it "Display the quick help buffer.",
which is only correct when you haven't `C-h ?' first.
So this is confusing on several different levels at the same time, and I
don't know what the best fix here would be.
Perhaps Philip of Stefan has some ideas; added to the CCs.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 10:22:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 58543 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> As Subject says: "C-h ?" doesn't show the 'q' key, it shows this
>> instead:
>>
>> M-x help-quick-or-quit Display the quick help buffer.
>>
>> This is sub-optimal, I think, and will help users who need this "quick
>> help" less than it could be.
>>
>> Thinking about it, perhaps 'q'; should be on the first line shown by
>> "C-h ?".
>
> Hm... It's rather confusing all over now. All the other commands after
> `C-h ?' do the same as typing the commands directly.
>
> That is, `C-h t' shows the Emacs tutorial, and `C-h ? t' does the same.
>
> `C-h q' shows the quick help, but `C-h ? q' doesn't -- it just exits
> `help-for-help'.
>
> But the help-for-help says that it "Display the quick help buffer.",
> which is only correct when you haven't `C-h ?' first.
>
> So this is confusing on several different levels at the same time, and I
> don't know what the best fix here would be.
It was probably wrong to add `help-quick-or-quit' to C-h ? in the first
place. My proposal to bind C-h q to `help-quick-or-quit' was that "C-h
q" had no effect *outside of* the Metahelp buffer. But of course, in
the Metahelp buffer "q" does have an effect, that overrides
`help-quick-or-quit'. My guess is that that is the reason why the
binding is displayed using M-x.
I would therefore remove entry from the "(make-help-screen
help-for-help" block, and consider some other place to mention the quick
help buffer.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 10:40:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 58543 <at> debbugs.gnu.org (full text, mbox):
> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 58543 <at> debbugs.gnu.org, Stefan Kangas
> <stefankangas <at> gmail.com>
> Date: Sun, 16 Oct 2022 10:21:05 +0000
>
> I would therefore remove entry from the "(make-help-screen
> help-for-help" block, and consider some other place to mention the quick
> help buffer.
How about mentioning it in the "C-h" prompt itself?
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 11:12:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 58543 <at> debbugs.gnu.org (full text, mbox):
Eli Zaretskii <eliz <at> gnu.org> writes:
>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, 58543 <at> debbugs.gnu.org, Stefan Kangas
>> <stefankangas <at> gmail.com>
>> Date: Sun, 16 Oct 2022 10:21:05 +0000
>>
>> I would therefore remove entry from the "(make-help-screen
>> help-for-help" block, and consider some other place to mention the quick
>> help buffer.
>
> How about mentioning it in the "C-h" prompt itself?
Do you mean the "C-h (Type ? for further options)-" prompt?
One place I thought could make sense would be the
`startup-echo-area-message' prompt, but that doesn't look like it has
enough space.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 11:44:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 58543 <at> debbugs.gnu.org (full text, mbox):
> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: larsi <at> gnus.org, 58543 <at> debbugs.gnu.org, stefankangas <at> gmail.com
> Date: Sun, 16 Oct 2022 11:11:20 +0000
>
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> >> From: Philip Kaludercic <philipk <at> posteo.net>
> >> Cc: Eli Zaretskii <eliz <at> gnu.org>, 58543 <at> debbugs.gnu.org, Stefan Kangas
> >> <stefankangas <at> gmail.com>
> >> Date: Sun, 16 Oct 2022 10:21:05 +0000
> >>
> >> I would therefore remove entry from the "(make-help-screen
> >> help-for-help" block, and consider some other place to mention the quick
> >> help buffer.
> >
> > How about mentioning it in the "C-h" prompt itself?
>
> Do you mean the "C-h (Type ? for further options)-" prompt?
Yes. Make it say
C-h (Type ? for further options, q for quick help)-
or somesuch.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 12:12:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 58543 <at> debbugs.gnu.org (full text, mbox):
Eli Zaretskii <eliz <at> gnu.org> writes:
> C-h (Type ? for further options, q for quick help)-
>
> or somesuch.
This is a nit, but is it just me that finds it confusing that the "-" is
all the way to the right?
IOW, shouldn't it say something like:
C-h- (Type ? for further options, q for quick help)
Or now that we have the `help-key-binding' maybe even
C-h- [? further options, q quick help]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 13:40:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 58543 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:
>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: larsi <at> gnus.org, 58543 <at> debbugs.gnu.org, stefankangas <at> gmail.com
>> Date: Sun, 16 Oct 2022 11:11:20 +0000
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> >> From: Philip Kaludercic <philipk <at> posteo.net>
>> >> Cc: Eli Zaretskii <eliz <at> gnu.org>, 58543 <at> debbugs.gnu.org, Stefan Kangas
>> >> <stefankangas <at> gmail.com>
>> >> Date: Sun, 16 Oct 2022 10:21:05 +0000
>> >>
>> >> I would therefore remove entry from the "(make-help-screen
>> >> help-for-help" block, and consider some other place to mention the quick
>> >> help buffer.
>> >
>> > How about mentioning it in the "C-h" prompt itself?
>>
>> Do you mean the "C-h (Type ? for further options)-" prompt?
>
> Yes. Make it say
>
> C-h (Type ? for further options, q for quick help)-
>
> or somesuch.
That sounds good. How about this patch:
[0001-src-keyboard.c-echo_add_key-Mention-quick-help.patch (text/x-patch, inline)]
From 8db3c0a25bf88f8e4669fd7e2babc2ff8f5c98b2 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk <at> posteo.net>
Date: Sun, 16 Oct 2022 15:38:28 +0200
Subject: [PATCH] * src/keyboard.c (echo_add_key): Mention quick-help
---
src/keyboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/keyboard.c b/src/keyboard.c
index 8ab4a451b4..8386b599c3 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -503,7 +503,7 @@ echo_add_key (Lisp_Object c)
if ((NILP (echo_string) || SCHARS (echo_string) == 0)
&& help_char_p (c))
{
- AUTO_STRING (str, " (Type ? for further options)");
+ AUTO_STRING (str, " (Type ? for further options, q for quick help)");
AUTO_LIST2 (props, Qface, Qhelp_key_binding);
Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str);
new_string = concat2 (new_string, str);
--
2.37.3
[Message part 3 (text/plain, inline)]
Stefan Kangas <stefankangas <at> gmail.com> writes:
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> C-h (Type ? for further options, q for quick help)-
>>
>> or somesuch.
>
> This is a nit, but is it just me that finds it confusing that the "-" is
> all the way to the right?
>
> IOW, shouldn't it say something like:
>
> C-h- (Type ? for further options, q for quick help)
>
> Or now that we have the `help-key-binding' maybe even
>
> C-h- [? further options, q quick help]
Ah, I didn't understand what the trailing dash was supposed to signify
so this looks like a good idea.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 14:04:01 GMT)
Full text and
rfc822 format available.
Message #29 received at 58543 <at> debbugs.gnu.org (full text, mbox):
> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: larsi <at> gnus.org, 58543 <at> debbugs.gnu.org, stefankangas <at> gmail.com
> Date: Sun, 16 Oct 2022 13:39:12 +0000
>
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> >> > How about mentioning it in the "C-h" prompt itself?
> >>
> >> Do you mean the "C-h (Type ? for further options)-" prompt?
> >
> > Yes. Make it say
> >
> > C-h (Type ? for further options, q for quick help)-
> >
> > or somesuch.
>
> That sounds good. How about this patch:
LGTM, but please wait for others to comment. After all, I'm not the
main audience for this stuff ;-)
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 14:25:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 58543 <at> debbugs.gnu.org (full text, mbox):
Eli Zaretskii <eliz <at> gnu.org> writes:
> LGTM, but please wait for others to comment.
Makes sense to me.
> After all, I'm not the main audience for this stuff ;-)
Me neither.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 16:51:01 GMT)
Full text and
rfc822 format available.
Message #35 received at 58543 <at> debbugs.gnu.org (full text, mbox):
Philip Kaludercic <philipk <at> posteo.net> writes:
> diff --git a/src/keyboard.c b/src/keyboard.c
> index 8ab4a451b4..8386b599c3 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -503,7 +503,7 @@ echo_add_key (Lisp_Object c)
> if ((NILP (echo_string) || SCHARS (echo_string) == 0)
> && help_char_p (c))
> {
> - AUTO_STRING (str, " (Type ? for further options)");
> + AUTO_STRING (str, " (Type ? for further options, q for quick help)");
> AUTO_LIST2 (props, Qface, Qhelp_key_binding);
> Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str);
Also add the text property to the "q" here. Something like:
Fadd_text_properties (make_fixnum (30), make_fixnum (31), props, str);
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#58543
; Package
emacs
.
(Sun, 16 Oct 2022 22:40:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 58543 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:
>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: larsi <at> gnus.org, 58543 <at> debbugs.gnu.org, stefankangas <at> gmail.com
>> Date: Sun, 16 Oct 2022 13:39:12 +0000
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> >> > How about mentioning it in the "C-h" prompt itself?
>> >>
>> >> Do you mean the "C-h (Type ? for further options)-" prompt?
>> >
>> > Yes. Make it say
>> >
>> > C-h (Type ? for further options, q for quick help)-
>> >
>> > or somesuch.
>>
>> That sounds good. How about this patch:
>
> LGTM, but please wait for others to comment. After all, I'm not the
> main audience for this stuff ;-)
Will do.
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> LGTM, but please wait for others to comment.
>
> Makes sense to me.
>
>> After all, I'm not the main audience for this stuff ;-)
>
> Me neither.
Looks like nobody will be using the feature :')
Stefan Kangas <stefankangas <at> gmail.com> writes:
> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> diff --git a/src/keyboard.c b/src/keyboard.c
>> index 8ab4a451b4..8386b599c3 100644
>> --- a/src/keyboard.c
>> +++ b/src/keyboard.c
>> @@ -503,7 +503,7 @@ echo_add_key (Lisp_Object c)
>> if ((NILP (echo_string) || SCHARS (echo_string) == 0)
>> && help_char_p (c))
>> {
>> - AUTO_STRING (str, " (Type ? for further options)");
>> + AUTO_STRING (str, " (Type ? for further options, q for quick help)");
>> AUTO_LIST2 (props, Qface, Qhelp_key_binding);
>> Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str);
>
> Also add the text property to the "q" here. Something like:
>
> Fadd_text_properties (make_fixnum (30), make_fixnum (31), props,
> str);
You're right, I've added it and it does the right thing:
[0001-src-keyboard.c-echo_add_key-Mention-quick-help.patch (text/x-patch, inline)]
From c25e78d8020364e1ecae795ffb79b1612bdc0d0b Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk <at> posteo.net>
Date: Mon, 17 Oct 2022 00:36:06 +0200
Subject: [PATCH] * src/keyboard.c (echo_add_key): Mention quick-help
---
src/keyboard.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/keyboard.c b/src/keyboard.c
index 8ab4a451b4..224512bfc9 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -503,9 +503,11 @@ echo_add_key (Lisp_Object c)
if ((NILP (echo_string) || SCHARS (echo_string) == 0)
&& help_char_p (c))
{
- AUTO_STRING (str, " (Type ? for further options)");
+ AUTO_STRING (str, " (Type ? for further options, q for quick help)");
AUTO_LIST2 (props, Qface, Qhelp_key_binding);
Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str);
+ Fadd_text_properties (make_fixnum (30), make_fixnum (31), props,
+str);
new_string = concat2 (new_string, str);
}
--
2.37.3
Reply sent
to
Philip Kaludercic <philipk <at> posteo.net>
:
You have taken responsibility.
(Fri, 04 Nov 2022 23:00:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Eli Zaretskii <eliz <at> gnu.org>
:
bug acknowledged by developer.
(Fri, 04 Nov 2022 23:00:01 GMT)
Full text and
rfc822 format available.
Message #43 received at 58543-done <at> debbugs.gnu.org (full text, mbox):
Philip Kaludercic <philipk <at> posteo.net> writes:
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: Philip Kaludercic <philipk <at> posteo.net>
>>> Cc: larsi <at> gnus.org, 58543 <at> debbugs.gnu.org, stefankangas <at> gmail.com
>>> Date: Sun, 16 Oct 2022 13:39:12 +0000
>>>
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>
>>> >> > How about mentioning it in the "C-h" prompt itself?
>>> >>
>>> >> Do you mean the "C-h (Type ? for further options)-" prompt?
>>> >
>>> > Yes. Make it say
>>> >
>>> > C-h (Type ? for further options, q for quick help)-
>>> >
>>> > or somesuch.
>>>
>>> That sounds good. How about this patch:
>>
>> LGTM, but please wait for others to comment. After all, I'm not the
>> main audience for this stuff ;-)
>
> Will do.
The patch has been pushed a while ago, so I am closing the report.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sat, 03 Dec 2022 12:24:09 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 203 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.