GNU bug report logs - #58453
28.2; project-query-replace-regexp fails because of directories in list

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58453 in the body.
You can then email your comments to 58453 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Nikander <robert.nikander <at> icloud.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.2; project-query-replace-regexp fails because of directories in
 list
Date: Tue, 11 Oct 2022 08:58:34 -0500

Hi

I’ve been getting errors from `project-query-replace-regexp` (it just beeps and gives an error about something being a directory). I’ve tracked it down to `project--vc-list-files`, which gets a list in a variable `files` by calling `git ls-files`. But that returns a few directories on my system, maybe because I’m using git submodules. Later the error occurs with stack trace:

    Debugger entered--Lisp error: (file-error "Read error" "Is a directory” ….)
    insert-file-contents(“….”)
    fileloop-next-file(t)
    fileloop-continue()
    project-query-replace-regexp("StyleDict" "StyleMap")

I’ve fixed the bug for my purposes by adding this line to that `project--vc-list-files` function in `project.el`...

    (setq files (seq-remove 'file-directory-p files))

But maybe there’s a better way. 

Rob



In GNU Emacs 28.2 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95))
 of 2022-09-12 built on builder10-14.lan
Windowing system distributor 'Apple', version 10.3.2290
System Description:  macOS 13.0

Configured using:
 'configure --with-ns '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp' --with-modules'

Configured features:
ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER THREADS
TOOLKIT_SCROLL_BARS ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ELisp/l

Minor modes in effect:
  shell-dirtrack-mode: t
  ivy-mode: t
  org-extra-emphasis-intraword-emphasis-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort emacsbug sendmail two-column sh-script smie executable
disp-table org-bullets org-indent rng-xsd xsd-regexp rng-cmpct rng-nxml
rng-valid nxml-mode nxml-outln nxml-rap sgml-mode facemenu flymake-cc
markdown-mode cmake-mode rst rect dabbrev etags cap-words superword
subword cc-mode cc-fonts cc-guess cc-menus cc-cmds swift-mode
swift-mode-imenu swift-mode-repl swift-mode-beginning-of-defun
swift-mode-font-lock swift-mode-standard-types swift-mode-indent
swift-mode-lexer tutorial mail-extr cus-start cl-print shortdoc pulse
help-fns radix-tree misearch multi-isearch edebug fileloop vc-mtn vc-hg
vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc
vc-dispatcher dired-aux ffap tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat shell ls-lisp ol-w3m org-tempo
tempo ol-rmail ol-mhe ol-irc ol-info org-habit ol-gnus nnselect
gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015
mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start
gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo
parse-time gnus-spec gnus-int gnus-range message rfc822 mml mml-sec epa
derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev
gmm-utils mailheader gnus-win ol-eww eww xdg url-queue shr kinsoku svg
xml dom mm-url gnus nnheader gnus-util rmail rmail-loaddefs mail-utils
ol-doi org-link-doi ol-docview doc-view jka-compr image-mode exif dired
dired-loaddefs ol-bibtex ol-bbdb finder-inf eglot array filenotify
jsonrpc ert ewoc debug backtrace xref flymake-proc flymake thingatpt
warnings compile text-property-search project imenu cl-extra yasnippet
help-mode cc-styles cc-align cc-engine cc-vars cc-defs ivy flx delsel
ivy-faces ivy-overlay colir color org-extra-emphasis pcase htmlfontify
htmlfontify-loaddefs cus-edit pp cus-load wid-edit ox-odt rng-loc
rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table
ox-ascii ox-publish ox edmacro kmacro org-download org-element avl-tree
generator org-attach org-id org-refile org ob ob-tangle ob-ref ob-lob
ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete
pcomplete comint ansi-color ring org-list org-faces org-entities
noutline outline easy-mmode org-version ob-emacs-lisp ob-core ob-eval
org-table oc-basic bibtex iso8601 time-date ol rx org-keys oc org-compat
advice org-macs org-loaddefs format-spec find-func cal-menu calendar
cal-loaddefs url-http url-auth mail-parse rfc2231 rfc2047 rfc2045
mm-util ietf-drums mail-prsvr url-gw nsm rmc puny async info package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads kqueue
cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 1048628 152211)
 (symbols 48 61892 11)
 (strings 32 263625 22350)
 (string-bytes 1 7168601)
 (vectors 16 87090)
 (vector-slots 8 2364739 177797)
 (floats 8 542 704)
 (intervals 56 83284 2732)
 (buffers 992 124))

Message #8 received at 58453 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Robert Nikander <robert.nikander <at> icloud.com>, 58453 <at> debbugs.gnu.org
Subject: Re: bug#58453: 28.2; project-query-replace-regexp fails because of
 directories in list
Date: Wed, 12 Oct 2022 00:06:09 +0300

On 11.10.2022 16:58, Robert Nikander via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Hi
> 
> I’ve been getting errors from `project-query-replace-regexp` (it just beeps and gives an error about something being a directory). I’ve tracked it down to `project--vc-list-files`, which gets a list in a variable `files` by calling `git ls-files`. But that returns a few directories on my system, maybe because I’m using git submodules. Later the error occurs with stack trace:
> 
>      Debugger entered--Lisp error: (file-error "Read error" "Is a directory” ….)
>      insert-file-contents(“….”)
>      fileloop-next-file(t)
>      fileloop-continue()
>      project-query-replace-regexp("StyleDict" "StyleMap")
> 
> I’ve fixed the bug for my purposes by adding this line to that `project--vc-list-files` function in `project.el`...
> 
>      (setq files (seq-remove 'file-directory-p files))
> 
> But maybe there’s a better way.

Hi!

This has been fixed on master a few months ago: 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55382

I've just bumped project.el's version to 0.8.2, you should be able to 
install it from GNU ELPA tomorrow (or perhaps a bit earlier).

Message #11 received at 58453 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>,
 Robert Nikander <robert.nikander <at> icloud.com>, 58453 <at> debbugs.gnu.org
Subject: Re: bug#58453: 28.2; project-query-replace-regexp fails because of
 directories in list
Date: Wed, 12 Oct 2022 02:38:02 -0700

forcemerge 55382 58453
thanks

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> This has been fixed on master a few months ago:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55382

I'm consequently merging these bugs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.