GNU bug report logs - #58447
[PATCH] In project-find-file, add absolute file name to history

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Augusto Stoffel <arstoffel <at> gmail.com>
Subject: bug#58447: closed (Re: bug#58447: [PATCH] In project-find-file,
 add absolute file name to history)
Date: Sat, 26 Nov 2022 02:30:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#58447: [PATCH] In project-find-file, add absolute file name to history

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 58447 <at> debbugs.gnu.org.

-- 
58447: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58447
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Juri Linkov <juri <at> linkov.net>,
 58447-done <at> debbugs.gnu.org
Subject: Re: bug#58447: [PATCH] In project-find-file, add absolute file name
 to history
Date: Sat, 26 Nov 2022 04:28:50 +0200

On 18/11/22 18:28, Augusto Stoffel wrote:
> On Wed,  2 Nov 2022 at 00:14, Dmitry Gutov wrote:
> 
>> On 01.11.2022 19:30, Juri Linkov wrote:
>>>> I'm not quite sure what Juri meant here.  If from some project I do
>>>>
>>>>     C-x p f /tmp RET RET
>>>>
>>>> then Emacs opens the /tmp dired buffer (RET twice because REQUIRE-MATCH
>>>> is 'confirm), as I think it should.
>>> Actually, that [Confirm] part is not quite a hassle, so your patch
>>> already handles that in both ways, thanks for this.
>> Thanks for verifying.
>>
>> LGTM then.
> FTR, someone would have to install the patch on my behalf.  I've
> attached it again for your convenience.

Sorry, I figured you had commit access.

Now pushed, thanks.

[Message part 3 (message/rfc822, inline)]

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] In project-find-file, add absolute file name to history
Date: Tue, 11 Oct 2022 20:29:24 +0200

[Message part 4 (text/plain, inline)]

Tags: patch

`project-find-file' and related commands share their history with more
general commands like `find-file', so they should add the absolute file
name to history.  Currently, file names relative to the project root are
added.  The attached patch fixes this.

I've also replaced `concat' with `expand-file-name' at a certain point.
I see no reason why one shouldn't do that, but please have a look.

[0001-In-project-find-file-and-the-like-add-absolute-file-.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.