GNU bug report logs - #58448
[PATCH] gnu: helm: fix not finding Factory Presets

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58448 in the body.
You can then email your comments to 58448 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: helm: fix not finding Factory Presets
Date: Tue, 11 Oct 2022 18:34:21 +0000

* gnu/packages/music.scm (helm): Fix not finding Factory Presets.
  This change fixes hardcoded paths so that Factory Presets can be found.
---
 gnu/packages/music.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 6b37c79389..000b372303 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -6144,6 +6144,13 @@ (define-public helm
              (substitute* "Makefile"
                (("/usr") ""))
              #t))
+         (add-after 'unpack 'fix-hardcoded-paths
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* "src/common/load_save.cpp"
+               (("/usr") (assoc-ref outputs "out")))
+             (substitute* "src/editor_sections/patch_browser.cpp"
+               (("/usr") (assoc-ref outputs "out")))
+             #t))
          (delete 'configure))))
     (inputs
      `(("alsa-lib" ,alsa-lib)
-- 
2.38.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sughosha via Guix-patches via <guix-patches <at> gnu.org>
Cc: Sughosha <Sughosha <at> proton.me>, 58448-done <at> debbugs.gnu.org
Subject: Re: [bug#58448] [PATCH] gnu: helm: fix not finding Factory Presets
Date: Sat, 29 Oct 2022 23:53:59 +0200

Hello,

Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/music.scm (helm): Fix not finding Factory Presets.
>   This change fixes hardcoded paths so that Factory Presets can be
>   found.

Thank you.  Applied with the following changes:

> +         (add-after 'unpack 'fix-hardcoded-paths
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "src/common/load_save.cpp"
> +               (("/usr") (assoc-ref outputs "out")))
> +             (substitute* "src/editor_sections/patch_browser.cpp"
> +               (("/usr") (assoc-ref outputs "out")))
> +             #t))

I removed trailing #t, and merged both substitute* calls.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.