GNU bug report logs - #58447
[PATCH] In project-find-file, add absolute file name to history

Previous Next

Full log

Message #172 received at 58447 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Augusto Stoffel <arstoffel <at> gmail.com>,
 58447 <at> debbugs.gnu.org
Subject: Re: bug#58447: [PATCH] In project-find-file, add absolute file name
 to history
Date: Fri, 16 Dec 2022 09:48:09 +0200

>>>> But please also note that its value 'project--read-file-absolute'
>>>> is also broken.  It asks confirmation for re-visiting even absolute
>>>> filenames, because currently 'C-x p f' adds abbreviated filenames,
>>>> but confirmation checks for absolute.
>>> Does the breakage show itself only when you add a history entry using one
>>> value of project-read-file-name-function and then try to look it up when
>>> using another value of project-read-file-name-function?
>>>
>>> If so, that's probably bearable enough for now (people don't really change
>>> this value often). Fixing it will require resolving the abbreviation
>>> situation. And we might as well switch to relative names in project-files
>>> first.
>> Visiting with 'C-x C-f' adds an abbreviated file name to the history.
>> So it looks strange that 'C-x p f M-p' doesn't understand that it's
>> absolute even though it's abbreviated.
>
> Fair enough.
>
> Can we do something with it, though, without piping all-files through
> #'expand-file-name?

In theory, it should be sufficient to pipe through #'expand-file-name
only the completion candidate to try both with and without
#'expand-file-name.  But in practice this might require
implementing this as the CONFIRM function.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.