GNU bug report logs - #58447
[PATCH] In project-find-file, add absolute file name to history

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58447 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history
Date: Thu, 15 Dec 2022 16:08:04 +0200

On 15/12/2022 13:07, Augusto Stoffel wrote:
> On Thu, 15 Dec 2022 at 01:04, Dmitry Gutov wrote:
> 
>> We're probably talking about the same thing, if the filtering is going
>> to use the list of files from project-files, rather than
>> file-exists-p. In either case, the user could actually input a
>> non-existent file (or file not in the completion table) which would
>> fail that test. But they'll hopefully hit C-x C-s soon after.
> My suggestion was not to filer based on project-files, but rather simply
> by file name prefixes.  Which, if I read correctly, is exactly what your
> patch v2 does.

Ah yes.

>> The patches could be combined, but v1 seems to be too invasive for
>> emacs-29, yet v2 could be just small enough to be considered
>> "bugfix-only".
>>
>> So, what does everyone think about the latter?
>>
>> If people agree that the v2 patch is an improvement, we can check it
>> in and leave project-local histories until later.
> In fact I think v2 already is a completely satisfactory implementation
> the project-local file history feature.

It seems like there are two incompatible behaviors here and you and Juri 
want. One is to filter by current project, and another to be able to 
reuse previous inputs freely.

If forced to choose, I would be slightly inclined toward the latter 
(which could be implemented using text properties, although the concept 
is a little awkward). But both are reasonable.

I think we should install one of them and then later (on master) add a 
user option to switch to the other behavior.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.