GNU bug report logs - #58312
Improve “Invalid face attribute” error message

Previous Next

Full log

Message #18 received at 58312 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: felix.dietrich <at> sperrhaken.name, luangruo <at> yahoo.com, larsi <at> gnus.org,
 58312 <at> debbugs.gnu.org
Subject: Re: bug#58312: Improve “Invalid face
 attribute” error message
Date: Wed, 10 Jan 2024 15:38:00 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Wed, 10 Jan 2024 02:50:46 -0800
> Cc: Felix Dietrich <felix.dietrich <at> sperrhaken.name>, 58312 <at> debbugs.gnu.org, eliz <at> gnu.org, 
> 	Po Lu <luangruo <at> yahoo.com>
> 
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> 
> > Felix Dietrich <felix.dietrich <at> sperrhaken.name> writes:
> >
> >> Could the log message “Invalid face attribute” created by
> >> “xfaces.c:merge_face_ref” be extended to also include the buffer or
> >> other identifying information about its origin?
> >
> > Perhaps include the window name?  That would be less ambiguous than the
> > buffer name.
> 
> That makes sense to me.  Eli or Po Lu, WDYT about this change?

Patches welcome, but please take into account the fact that the window
is not always known there: merge_face_ref can be called with its first
argument NULL.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.