GNU bug report logs - #58311
Missing newline in *Messages* between evaluation result and error

Previous Next

To reply to this bug, email your comments to 58311 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felix Dietrich <felix.dietrich <at> sperrhaken.name>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Missing newline in *Messages* between evaluation result and error
Date: Wed, 05 Oct 2022 20:37:18 +0200

Package: emacs
Severity: minor

Entries added to the “*Messages*” buffer by the following snippet are
missing a newline between the evaluation result and the error log entry
put there by “xfaces.c:merge_face_ref” using “xdisp.c:add_to_log”.

#+begin_src emacs-lisp
  (let ((buf (generate-new-buffer "*test*"))
        (s (propertize "Hello World" 'face '(:foreground :invalid))))
    (with-current-buffer buf
      (insert s))
    (display-buffer buf))
#+end_src


#+begin_example
#<window 54 on *test*<2>>Invalid face attribute :foreground :invalid
Invalid face attribute :foreground :invalid
#+end_example


-- 
Felix Dietrich

Message #8 received at 58311 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Felix Dietrich <felix.dietrich <at> sperrhaken.name>
Cc: 58311 <at> debbugs.gnu.org
Subject: Re: bug#58311: Missing newline in *Messages* between evaluation
 result and error
Date: Thu, 06 Oct 2022 14:41:08 +0200

Felix Dietrich <felix.dietrich <at> sperrhaken.name> writes:

> Entries added to the “*Messages*” buffer by the following snippet are
> missing a newline between the evaluation result and the error log entry
> put there by “xfaces.c:merge_face_ref” using “xdisp.c:add_to_log”.
>
> #+begin_src emacs-lisp
>   (let ((buf (generate-new-buffer "*test*"))
>         (s (propertize "Hello World" 'face '(:foreground :invalid))))
>     (with-current-buffer buf
>       (insert s))
>     (display-buffer buf))
> #+end_src
>
> #+begin_example
> #<window 54 on *test*<2>>Invalid face attribute :foreground :invalid
> Invalid face attribute :foreground :invalid
> #+end_example

Hm.  Very odd.  The code just calls

		      add_to_log ("Invalid face attribute %S %S",
				  QCinherit, parent_face);

the normal way, and reading the code and poking at this a bit, it seems
like add_to_log should insert a newline before inserting the text, but I
may be misreading message_dolog -- it's pretty long.

Is it "immediately obvious" to somebody else what is happening here?

Message #13 received at 58311 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Felix Dietrich <felix.dietrich <at> sperrhaken.name>
Cc: 58311 <at> debbugs.gnu.org
Subject: Re: bug#58311: Missing newline in *Messages* between evaluation
 result and error
Date: Thu, 06 Oct 2022 14:42:20 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Hm.  Very odd.  The code just calls
>
> 		      add_to_log ("Invalid face attribute %S %S",
> 				  QCinherit, parent_face);

Or rather, it's this bit, but the same applies:

	      if (err)
		{
		  add_to_log ("Invalid face attribute %S %S", keyword, value);
		  ok = false;
		}

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.