GNU bug report logs - #58291
29.0.50; MacOS compilation warning for possibly unitialized use in emacs.c

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58291: closed (29.0.50; MacOS compilation warning for
 possibly unitialized use in emacs.c)
Date: Tue, 04 Oct 2022 18:59:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 4 Oct 2022 20:57:57 +0200
with message-id <CADwFkmnHbcxjxoLwJXLU59O0iuJH-7X8annMv6G2XLa=p4m-sg <at> mail.gmail.com>
and subject line Re: bug#58291: 29.0.50; MacOS compilation warning for possibly unitialized use in emacs.c
has caused the debbugs.gnu.org bug report #58291,
regarding 29.0.50; MacOS compilation warning for possibly unitialized use in emacs.c
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58291: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58291
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; MacOS compilation warning for possibly unitialized use in
 emacs.c
Date: Tue, 04 Oct 2022 17:26:32 +0200

In GNU Emacs 29.0.50 (build 5, aarch64-apple-darwin21.6.0, NS
 appkit-2113.60 Version 12.6 (Build 21G115)) of 2022-10-04 built on
 Mini.fritz.box
Repository revision: 849b7756fd31a69791e67dfe010b1e10f0168c83
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.6

This is latest master as of writing this.  When compiling emacs, I see

emacs.c:899:7: warning: variable 'bufsize' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
  if (!(emacs_executable && *emacs_executable))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emacs.c:964:7: note: uninitialized use occurs here
  if (bufsize < needed)
      ^~~~~~~
emacs.c:899:3: note: remove the 'if' if its condition is always false
  if (!(emacs_executable && *emacs_executable))
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emacs.c:928:3: note: variable 'bufsize' is declared here
  ptrdiff_t bufsize = exenamelen + strlen (suffix) + 1;
  ^
emacs.c:1755:17: warning: 'fork' is deprecated: Use posix_spawn or fork [-Wdeprecated-declarations]
            f = fork ();  /* in orig */

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 58291-done <at> debbugs.gnu.org, Andreas Schwab <schwab <at> linux-m68k.org>
Subject: Re: bug#58291: 29.0.50; MacOS compilation warning for possibly
 unitialized use in emacs.c
Date: Tue, 4 Oct 2022 20:57:57 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
>
>> This is latest master as of writing this.  When compiling emacs, I see
>>
>> emacs.c:899:7: warning: variable 'bufsize' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>>   if (!(emacs_executable && *emacs_executable))
>>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> emacs.c:964:7: note: uninitialized use occurs here
>>   if (bufsize < needed)
>>       ^~~~~~~
>
> I guess this might be related to Andreas' recent fix?  Added to the CCs.

This is fixed on emacs-28 and merged to master.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.