GNU bug report logs - #58292
[Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition

Previous Next

Package: emacs;

Reported by: Thuna <thuna.cing <at> gmail.com>

Date: Tue, 4 Oct 2022 17:39:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58292 in the body.
You can then email your comments to 58292 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58292; Package emacs. (Tue, 04 Oct 2022 17:39:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Thuna <thuna.cing <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 04 Oct 2022 17:39:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thuna <thuna.cing <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition
Date: Tue, 04 Oct 2022 19:38:39 +0200

[Message part 1 (text/plain, inline)]
Currently, `define-minor-mode' signals an error upon evaluation.
Looking into it, it seems that is because there are not keyword
arguments given to it, which causes a problem according the docstring of
`define-minor-mode':
> If you provide BODY, then you must provide at least one keyword
> argument (e.g. ‘:lighter nil‘).

This patch should fix the issue.

[0001-Fix-bad-minor-mode-definition.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58292; Package emacs. (Tue, 04 Oct 2022 19:06:01 GMT) Full text and rfc822 format available.

Message #8 received at 58292 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Thuna <thuna.cing <at> gmail.com>
Cc: 58292 <at> debbugs.gnu.org
Subject: Re: bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode
 definition
Date: Tue, 04 Oct 2022 21:04:55 +0200

Thuna <thuna.cing <at> gmail.com> writes:

> Currently, `define-minor-mode' signals an error upon evaluation.
> Looking into it, it seems that is because there are not keyword
> arguments given to it, which causes a problem according the docstring of
> `define-minor-mode':
>> If you provide BODY, then you must provide at least one keyword
>> argument (e.g. ‘:lighter nil‘).
>
> This patch should fix the issue.

Looks like this was fixed earlier today by:

commit c206181d57c235b0a5f788b974d98e9cf1f7c4ec
Author:     Philip Kaludercic <philipk <at> posteo.net>
AuthorDate: Mon Oct 3 15:15:18 2022 +0200
Commit:     Philip Kaludercic <philipk <at> posteo.net>
CommitDate: Tue Oct 4 20:01:44 2022 +0200

    * rcirc-color.el (rcirc-color-mode): Add :global t
    
    Without at least one keyword argument, the body in interpreted as the
    an expression setting the initial value of the `rcirc-color-mode' via
    the legacy syntax from Emacs 21.
bug marked as fixed in version 29.1, send any further explanations to 58292 <at> debbugs.gnu.org and Thuna <thuna.cing <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 04 Oct 2022 19:06:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 02 Nov 2022 11:24:12 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 282 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.