GNU bug report logs - #5827
[PATCH] tail: include sys/vfs.h

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#5827: marked as done ([PATCH] tail: include sys/vfs.h)
Date: Mon, 05 Apr 2010 09:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 05 Apr 2010 11:43:35 +0200
with message-id <87r5muw7y0.fsf <at> meyering.net>
and subject line Re: bug#5827: [PATCH] tail: include sys/vfs.h
has caused the GNU bug report #5827,
regarding [PATCH] tail: include sys/vfs.h
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
5827: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5827
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marc Kleine-Budde <mkl <at> pengutronix.de>
To: bug-coreutils <at> gnu.org
Cc: Marc Kleine-Budde <mkl <at> pengutronix.de>
Subject: [PATCH] tail: include sys/vfs.h
Date: Sat,  3 Apr 2010 15:52:18 +0200

Hello,

the latest coreutils release 8.4 and current git master fail during the
(cross-) compilation of tail. The used components are:

gcc-4.3.2
glibc-2.8
binutils-2.18

The following patch fixes the commit. It's against git master, but should
apply on 8.4, too.

Please review and consider inclusion.

Cheers, Marc


From ebf1ab5bcba6f6b82bb8f0a62c949858e2a9d5cc Mon Sep 17 00:00:00 2001
From: Marc Kleine-Budde <mkl <at> pengutronix.de>
Date: Sat, 3 Apr 2010 14:42:29 +0200
Subject: [PATCH] tail: include sys/vfs.h

This patch fixes the following error:

tail.c: In function 'fremote':
tail.c:882: error: storage size of 'buf' isn't known
tail.c:883: warning: implicit declaration of function 'fstatfs'

Signed-off-by: Marc Kleine-Budde <mkl <at> pengutronix.de>
---
 src/tail.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/tail.c b/src/tail.c
index 02c4a1a..d0bc957 100644
--- a/src/tail.c
+++ b/src/tail.c
@@ -57,6 +57,9 @@
 # if HAVE_SYS_STATFS_H
 #  include <sys/statfs.h>
 # endif
+# if HAVE_SYS_VFS_H
+#  include <sys/vfs.h>
+# endif
 #endif
 
 /* The official name of this program (e.g., no `g' prefix).  */
-- 
1.7.0.3

[Message part 3 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Marc Kleine-Budde <mkl <at> pengutronix.de>
Cc: 5827-done <at> debbugs.gnu.org
Subject: Re: bug#5827: [PATCH] tail: include sys/vfs.h
Date: Mon, 05 Apr 2010 11:43:35 +0200

Marc Kleine-Budde wrote:
...
>> I'd like to take a slightly more conservative approach,
>> including sys/vfs.h only when sys/statfs.h is not available.
>> Does this work for you?
>
> Thanks, works, even with older gcc/glibc combinations.

Thanks.
Pushed, along with a gnulib update.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.