GNU bug report logs - #58256
Possible mistake in recent `dired-do-flagged-delete' change

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefankangas <at> gmail.com>

Date: Sun, 2 Oct 2022 18:43:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #16 received at 58256 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 58256 <at> debbugs.gnu.org
Subject: Re: bug#58256: Possible mistake in recent `dired-do-flagged-delete'
 change
Date: Mon, 3 Oct 2022 00:30:13 +0200
close 58256 29.1
thanks

Stephen Berman <stephen.berman <at> gmx.net> writes:

> Yeah, it looks like I mistakenly put the dolist in the 'else' clause
> instead of the 'then' clause.  Thanks for catching that.
[...]
> I think doing it that way leaves the markers in the buffer, though
> probably for typical use cases that's not a problem, and it is simpler
> that way (as I noted when I posted my patch).  I guess the same
> simplification can be applied to `dired-do-delete' as well.

OK.  Let's stick with the more correct way and actually delete the
markers.

I've done this in commit 0d0d59b32c, and I'm closing this bug report.




This bug report was last modified 2 years and 295 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.