GNU bug report logs - #58255
29.0.50; don't remove thumbnails in image-dired-do-flagged-delete until confirmation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58255 in the body.
You can then email your comments to 58255 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Münster <pm <at> a16n.net>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; don't remove thumbnails in image-dired-do-flagged-delete
 until confirmation
Date: Sun, 02 Oct 2022 19:22:47 +0200

[Message part 1 (text/plain, inline)]

Hi,

As suggested by Stefan Kangas, please find here attached a patch, that
changes image-dired-do-flagged-delete, so that thumbnails are removed
only, when images are actually deleted in the dired buffer.

Kind regards,
-- 
           Peter

[my-patch.diff (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 58255 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Peter Münster <pm <at> a16n.net>, 58255 <at> debbugs.gnu.org
Subject: Re: bug#58255: 29.0.50; don't remove thumbnails in
 image-dired-do-flagged-delete until confirmation
Date: Sun, 2 Oct 2022 20:26:57 +0200

tags 58255 + patch
close 58255 29.1
thanks

Peter Münster <pm <at> a16n.net> writes:

> As suggested by Stefan Kangas, please find here attached a patch, that
> changes image-dired-do-flagged-delete, so that thumbnails are removed
> only, when images are actually deleted in the dired buffer.

Thanks for the patch!  It looks good to me, so I've installed it on
master.

In the future, please use `git format-patch -1 HEAD' to produce the
patch, as that makes it easier to install.

Message #15 received at 58255 <at> debbugs.gnu.org (full text, mbox):

From: Peter Münster <pm <at> a16n.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 58255 <at> debbugs.gnu.org
Subject: Re: bug#58255: 29.0.50; don't remove thumbnails in
 image-dired-do-flagged-delete until confirmation
Date: Sun, 02 Oct 2022 21:36:06 +0200

[Message part 1 (text/plain, inline)]

On Sun, Oct 02 2022, Stefan Kangas wrote:

> In the future, please use `git format-patch -1 HEAD'

Sorry. Yes, I'll do that next time.

-- 
           Peter

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.