GNU bug report logs - #58249
[PATCH] gnu: packages: qt: Fix qtbase-5 not building on gcc 11 or later

Previous Next

Package: guix-patches;

Reported by: Mája Tomášek <maya.tomasek <at> disroot.org>

Date: Sun, 2 Oct 2022 14:23:02 UTC

Severity: normal

Tags: moreinfo, patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58249 in the body.
You can then email your comments to 58249 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#58249; Package guix-patches. (Sun, 02 Oct 2022 14:23:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mája Tomášek <maya.tomasek <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 02 Oct 2022 14:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mája Tomášek <maya.tomasek <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: packages: qt: Fix qtbase-5 not building on gcc 11 or
 later
Date: Sun, 02 Oct 2022 16:22:33 +0200
[Message part 1 (text/plain, inline)]
This fixes a bug that makes qtbase-5 unbuildable with gcc 11 and later

The QT issue https://bugreports.qt.io/browse/QTBUG-91909

This patch is based on conversation from
https://github.com/RPCS3/rpcs3/issues/10349

[0001-gnu-packages-qt-Fix-qtbase-5-not-building-on-gcc-11.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#58249; Package guix-patches. (Tue, 03 Jan 2023 22:20:01 GMT) Full text and rfc822 format available.

Message #8 received at 58249 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mája Tomášek <maya.tomasek <at> disroot.org>
Cc: 58249 <at> debbugs.gnu.org
Subject: Re: bug#58249: [PATCH] gnu: packages: qt: Fix qtbase-5 not building
 on gcc 11 or later
Date: Tue, 03 Jan 2023 17:18:58 -0500
Hi,

Mája Tomášek <maya.tomasek <at> disroot.org> writes:

> This fixes a bug that makes qtbase-5 unbuildable with gcc 11 and later
>
> The QT issue https://bugreports.qt.io/browse/QTBUG-91909
>
> This patch is based on conversation from
> https://github.com/RPCS3/rpcs3/issues/10349

That's good to know, but Guix is currently using GCC 10.3.0, so it is
not currently a concern.  Have you encountered a situation where it
caused an issue?  Perhaps our Qt 6 doesn't have this problem.  I'd
suggest we do nothing for now.

What do you think?

-- 
Thanks,
Maxim




Added tag(s) moreinfo. Request was from Maxim Cournoyer <maxim.cournoyer <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 03 Jan 2023 22:20:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#58249; Package guix-patches. (Sun, 08 Jan 2023 22:50:01 GMT) Full text and rfc822 format available.

Message #13 received at 58249 <at> debbugs.gnu.org (full text, mbox):

From: Mája Tomášek <maya.tomasek <at> disroot.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 58249 <at> debbugs.gnu.org
Subject: Re: bug#58249: [PATCH] gnu: packages: qt: Fix qtbase-5 not building
 on gcc 11 or later
Date: Sun, 08 Jan 2023 23:49:13 +0100
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi,
>
> Mája Tomášek <maya.tomasek <at> disroot.org> writes:
>
>> This fixes a bug that makes qtbase-5 unbuildable with gcc 11 and later
>>
>> The QT issue https://bugreports.qt.io/browse/QTBUG-91909
>>
>> This patch is based on conversation from
>> https://github.com/RPCS3/rpcs3/issues/10349
>
> That's good to know, but Guix is currently using GCC 10.3.0, so it is
> not currently a concern.  Have you encountered a situation where it
> caused an issue?

I have. I have written a recipe for a package (namely yuzu emulator),
which depends on GCC 12. And it was actually an issue, I had to wrap
qtbase with a wrapper that goes over this problem.

> Perhaps our Qt 6 doesn't have this problem.  I'd
> suggest we do nothing for now.

It was actually fixed in later versions of qtbase-5, but I'm not sure
how this exactly works and if they are elegible for use in Guix.

> What do you think?

I don't know, it is a hidden bug that is likely to cause quite a big
problem once Guix moves to GCC 11 or later, as many apps probably won't update to
Qt 6.

Kind regards,
Maya




Information forwarded to guix-patches <at> gnu.org:
bug#58249; Package guix-patches. (Tue, 10 Jan 2023 15:08:01 GMT) Full text and rfc822 format available.

Message #16 received at 58249 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mája Tomášek <maya.tomasek <at> disroot.org>
Cc: 58249 <at> debbugs.gnu.org
Subject: Re: bug#58249: [PATCH] gnu: packages: qt: Fix qtbase-5 not building
 on gcc 11 or later
Date: Tue, 10 Jan 2023 10:07:13 -0500
Hello,

Mája Tomášek <maya.tomasek <at> disroot.org> writes:

[...]

> I don't know, it is a hidden bug that is likely to cause quite a big
> problem once Guix moves to GCC 11 or later, as many apps probably won't update to
> Qt 6.

The best solution may be to update our Qt 5 version; would you like to
give it a try?  Other than being a lot of new hashes to update (for each
qt5 component), it should be relatively low risk (with regards to
breaking existing Qt 5 packages).

-- 
Thanks,
Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#58249; Package guix-patches. (Wed, 25 Jan 2023 21:05:01 GMT) Full text and rfc822 format available.

Message #19 received at 58249 <at> debbugs.gnu.org (full text, mbox):

From: Mája Tomášek <maya.tomasek <at> disroot.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 58249 <at> debbugs.gnu.org
Subject: Re: bug#58249: [PATCH] gnu: packages: qt: Fix qtbase-5 not building
 on gcc 11 or later
Date: Wed, 25 Jan 2023 22:03:58 +0100
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hello,
>
> Mája Tomášek <maya.tomasek <at> disroot.org> writes:
>
> [...]
>
>> I don't know, it is a hidden bug that is likely to cause quite a big
>> problem once Guix moves to GCC 11 or later, as many apps probably won't update to
>> Qt 6.
>
> The best solution may be to update our Qt 5 version; would you like to
> give it a try?  Other than being a lot of new hashes to update (for each
> qt5 component), it should be relatively low risk (with regards to
> breaking existing Qt 5 packages).
>
> -- 
> Thanks,
> Maxim

I haved looked into it, and guix has already shipped a patched version
:)

This can be closed now.
Maya




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Thu, 26 Jan 2023 16:41:02 GMT) Full text and rfc822 format available.

Notification sent to Mája Tomášek <maya.tomasek <at> disroot.org>:
bug acknowledged by developer. (Thu, 26 Jan 2023 16:41:02 GMT) Full text and rfc822 format available.

Message #24 received at 58249-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mája Tomášek <maya.tomasek <at> disroot.org>
Cc: 58249-done <at> debbugs.gnu.org
Subject: Re: bug#58249: [PATCH] gnu: packages: qt: Fix qtbase-5 not building
 on gcc 11 or later
Date: Thu, 26 Jan 2023 11:40:30 -0500
Hi,

Mája Tomášek <maya.tomasek <at> disroot.org> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> Hello,
>>
>> Mája Tomášek <maya.tomasek <at> disroot.org> writes:
>>
>> [...]
>>
>>> I don't know, it is a hidden bug that is likely to cause quite a big
>>> problem once Guix moves to GCC 11 or later, as many apps probably won't update to
>>> Qt 6.
>>
>> The best solution may be to update our Qt 5 version; would you like to
>> give it a try?  Other than being a lot of new hashes to update (for each
>> qt5 component), it should be relatively low risk (with regards to
>> breaking existing Qt 5 packages).
>>
>> -- 
>> Thanks,
>> Maxim
>
> I haved looked into it, and guix has already shipped a patched version
> :)
>
> This can be closed now.
> Maya

Great, thanks for the follow-up.

I'm closing this by replying to 58249-done <at> debbugs.gnu.org in CC.

-- 
Thanks,
Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 24 Feb 2023 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 172 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.