GNU bug report logs - #58199
29.0.50; Odd "git pull" output

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58199 <at> debbugs.gnu.org
Subject: bug#58199: 29.0.50; Odd "git pull" output
Date: Sat, 01 Oct 2022 15:37:03 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Those ^M characters look ugly.  Should the filter process here do
>> something about those?  Or are they part of some ANSI control character
>> sequence that's not parsed correctly, perhaps?
>
> No ANSI control sequences: that's Git overwriting its own output with
> later output, for aesthetic reasons.  We should convert those ^M
> characters to newline, I think.

Right.

Hm...  looking at the VC code, I see that vc-do-command sets a filter
`vc-process-filter' that's trivial -- I had expected that there would be
some mangling of the output already in there somewhere...

Oh, OK, I see that the backends do stuff like

        (add-function :around (process-filter proc)
                      #'vc-cvs-annotate-process-filter)

so I guess the fix here would be to make vc-git-pull do something
similar.

I'll give it a go.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.