GNU bug report logs - #58200
osc.el name conflict

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58200 in the body.
You can then email your comments to 58200 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: osc.el name conflict
Date: Fri, 30 Sep 2022 14:32:58 -0400

The recent extraction of comint's handling of SCO escape sequences into
`lisp/osc.el` is probably a good thing in general but it breaks GNU
ELPA's `osc` package :-(

Could we use another name for that file?


        Stefan

Message #8 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 58200 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>
Subject: Re: bug#58200: osc.el name conflict
Date: Fri, 30 Sep 2022 21:51:30 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> The recent extraction of comint's handling of SCO escape sequences into
> `lisp/osc.el` is probably a good thing in general but it breaks GNU
> ELPA's `osc` package :-(

Arg...  Sorry I didn't ear of that package until now.

> Could we use another name for that file?

Sure.  And I can do the renaming, but what would be a good name?
What do you think of osc-sequences.el?
-- 
Matthias

Message #11 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: 58200 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58200: osc.el name conflict
Date: Fri, 30 Sep 2022 21:57:03 +0200

Matthias Meulien <orontee <at> gmail.com> writes:

> Sure.  And I can do the renaming, but what would be a good name?
> What do you think of osc-sequences.el?

Would ansi-osc.el be totally misleading?

Message #14 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58200 <at> debbugs.gnu.org, Matthias Meulien <orontee <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58200: osc.el name conflict
Date: Fri, 30 Sep 2022 22:08:41 +0200

[Message part 1 (text/plain, inline)]

I think the file name in itself doesn't matter too much. But should we also
rename all symbols to have a matching prefix?

Sharing the osc- prefix is not as clean but I guess there's enough space in
it for the two packages...

On Fri, Sep 30, 2022, 21:57 Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Matthias Meulien <orontee <at> gmail.com> writes:
>
> > Sure.  And I can do the renaming, but what would be a good name?
> > What do you think of osc-sequences.el?
>
> Would ansi-osc.el be totally misleading?
>

[Message part 2 (text/html, inline)]

Message #17 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58200 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58200: osc.el name conflict
Date: Fri, 30 Sep 2022 22:10:14 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Matthias Meulien <orontee <at> gmail.com> writes:
>
>> Sure.  And I can do the renaming, but what would be a good name?
>> What do you think of osc-sequences.el?
>
> Would ansi-osc.el be totally misleading?

I am ok with that.

My understanding was that OSC sequences are more related to ECMA because
the most precise description I read is here:
https://www.ecma-international.org/publications-and-standards/standards/ecma-48/
but Wikipedia page on ANSI escape sequences tends to present OSC
sequences as a particular case of ANSI sequences, aligned with your
suggestion,
https://en.wikipedia.org/wiki/ANSI_escape_code#OSC_(Operating_System_Command)_sequences.

We could use the prefix ansi-osc- which isn't that long.
-- 
Matthias

Message #20 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58200 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58200: osc.el name conflict
Date: Fri, 30 Sep 2022 23:19:01 +0200

[Message part 1 (text/plain, inline)]

Matthias Meulien <orontee <at> gmail.com> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> Matthias Meulien <orontee <at> gmail.com> writes:
>>
>>> Sure.  And I can do the renaming, but what would be a good name?
>>> What do you think of osc-sequences.el?
>>
>> Would ansi-osc.el be totally misleading?
>
> I am ok with that.
>
> My understanding was that OSC sequences are more related to ECMA because
> the most precise description I read is here:
> https://www.ecma-international.org/publications-and-standards/standards/ecma-48/
> but Wikipedia page on ANSI escape sequences tends to present OSC
> sequences as a particular case of ANSI sequences, aligned with your
> suggestion,
> https://en.wikipedia.org/wiki/ANSI_escape_code#OSC_(Operating_System_Command)_sequences.
>
> We could use the prefix ansi-osc- which isn't that long.

A patch that renames related files and adds the ansi-osc- prefix is attached.

[0001-Rename-osc.el-to-ansi-osc.el-bug-58200.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Matthias

Message #23 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58200 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58200: osc.el name conflict
Date: Sat, 01 Oct 2022 08:50:01 +0200

[Message part 1 (text/plain, inline)]

Matthias Meulien <orontee <at> gmail.com> writes:

> A patch that renames related files and adds the ansi-osc- prefix is attached.

I just realized that the customization group hasn't been defined.

[0001-Define-ansi-osc-customization-group.patch (text/x-diff, inline)]

From da4bca9eb2b7c5d28e47e7c2bc522731c770d0e3 Mon Sep 17 00:00:00 2001
From: Matthias Meulien <orontee <at> gmail.com>
Date: Sat, 1 Oct 2022 08:46:50 +0200
Subject: [PATCH] Define ansi-osc customization group

* lisp/ansi-osc.el (ansi-osc): Define ansi-osc customization group
(ansi-osc-for-compilation-buffer): Fix wrong group
---
 lisp/ansi-osc.el | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/lisp/ansi-osc.el b/lisp/ansi-osc.el
index 67a8551628..34154998cd 100644
--- a/lisp/ansi-osc.el
+++ b/lisp/ansi-osc.el
@@ -155,6 +155,17 @@ ansi-osc-hyperlink-handler
         (and (string-match ";\\(.+\\)" text)
              (cons (point-marker) (match-string-no-properties 1 text)))))
 
+(defgroup ansi-osc nil
+  "Interpretation of OSC escape sequences.
+Handlers for OSC 2, 7 and 8 (for window title, current directory
+and hyperlinks respectively) are provided.  OSC (Operating System
+Commands) control sequences are defined in section 8.3.89 of the
+ECMA-48 standard is freely available at
+<URL:https://www.ecma-international.org/publications/standards/Ecma-048.htm>
+as a PDF file."
+  :version "29.1"
+  :group 'processes)
+
 (defcustom ansi-osc-for-compilation-buffer 'filter
   "What to do with OSC escape sequences in compilation output.
 
@@ -170,7 +181,7 @@ ansi-osc-for-compilation-buffer
   :type '(choice (const :tag "Do nothing" nil)
                  (const :tag "Filter out OSC" filter)
                  (other :tag "Translate OSC" t))
-  :group 'osc
+  :group 'ansi-osc
   :version "29.1")
 
 (defvar compilation-filter-start)
-- 
2.30.2

[Message part 3 (text/plain, inline)]

-- 
Matthias

Message #26 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: 58200 <at> debbugs.gnu.org, Matthias Meulien <orontee <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58200: osc.el name conflict
Date: Sat, 01 Oct 2022 11:57:55 +0200

Augusto Stoffel <arstoffel <at> gmail.com> writes:

> I think the file name in itself doesn't matter too much. But should we
> also rename all symbols to have a matching prefix?

Yup.

Message #29 received at 58200 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: 58200 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58200: osc.el name conflict
Date: Sat, 01 Oct 2022 11:59:08 +0200

Matthias Meulien <orontee <at> gmail.com> writes:

>> A patch that renames related files and adds the ansi-osc- prefix is attached.
>
> I just realized that the customization group hasn't been defined.

Thanks; I've now pushed the two patches to Emacs 29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.