GNU bug report logs - #58150
29.0.50; parse_tool_bar_item should not usually upcase "and"

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58150 <at> debbugs.gnu.org, spwhitton <at> spwhitton.name
Subject: bug#58150: 29.0.50; parse_tool_bar_item should not usually upcase "and"
Date: Fri, 30 Sep 2022 14:34:07 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Isn't the capitalizing for the likes of tool-bar-add-item-from-menu,
> where the symbols are commands that aren't capitalized?

In that case, the code is wrong, because it capitalises also in the
normal case (i.e., when not using tool-bar-add-item-from-menu).

Perhaps that's the case, and people got used to it fixing all the names,
and nobody noticed that stuff like

    (define-key map [isearch-occur]
      (list 'menu-item "Show hits" 'isearch-occur
            :help "Show each search hit"
            :image '(isearch-tool-bar-image "index")))

was wrong, because "Show hits" was never displayed "unfixed".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.